Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: PRESUBMIT.py

Issue 7789033: Add PRESUBMIT.py exclusion for cpplint_chromium.py. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for depot tools. 5 """Top-level presubmit script for depot tools.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into depot_tools. 8 details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 11
12 def CommonChecks(input_api, output_api, tests_to_black_list): 12 def CommonChecks(input_api, output_api, tests_to_black_list):
13 results = [] 13 results = []
14 import sys 14 import sys
15 if not sys.version.startswith('2.5'): 15 if not sys.version.startswith('2.5'):
16 # Depot_tools has the particularity that it needs to be tested on python 16 # Depot_tools has the particularity that it needs to be tested on python
17 # 2.5. But we don't want the presubmit check to fail if it is not installed. 17 # 2.5. But we don't want the presubmit check to fail if it is not installed.
18 results.append(output_api.PresubmitNotifyResult( 18 results.append(output_api.PresubmitNotifyResult(
19 'You should install python 2.5 and run ln -s $(which python2.5) python.' 19 'You should install python 2.5 and run ln -s $(which python2.5) python.'
20 '\n' 20 '\n'
21 'A great place to put this symlink is in depot_tools.\n' 21 'A great place to put this symlink is in depot_tools.\n'
22 'Otherwise, you break depot_tools on python 2.5, you get to keep the ' 22 'Otherwise, you break depot_tools on python 2.5, you get to keep the '
23 'pieces.')) 23 'pieces.'))
24 24
25 25
26 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) 26 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
27 black_list = list(input_api.DEFAULT_BLACK_LIST) + [ 27 black_list = list(input_api.DEFAULT_BLACK_LIST) + [
28 r'^cpplint\.py$', 28 r'^cpplint\.py$',
29 r'^cpplint_chromium\.py$',
29 r'^python_bin[\/\\].+', 30 r'^python_bin[\/\\].+',
30 r'^svn_bin[\/\\].+', 31 r'^svn_bin[\/\\].+',
31 r'^tests[\/\\]\w+?[\/\\].+'] 32 r'^tests[\/\\]\w+?[\/\\].+']
32 results.extend(input_api.canned_checks.RunPylint( 33 results.extend(input_api.canned_checks.RunPylint(
33 input_api, 34 input_api,
34 output_api, 35 output_api,
35 white_list=[r'.*\.py$'], 36 white_list=[r'.*\.py$'],
36 black_list=black_list)) 37 black_list=black_list))
37 38
38 # TODO(maruel): Make sure at least one file is modified first. 39 # TODO(maruel): Make sure at least one file is modified first.
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 106
106 107
107 def CheckChangeOnCommit(input_api, output_api): 108 def CheckChangeOnCommit(input_api, output_api):
108 output = [] 109 output = []
109 output.extend(CommonChecks(input_api, output_api, [])) 110 output.extend(CommonChecks(input_api, output_api, []))
110 output.extend(input_api.canned_checks.CheckDoNotSubmit( 111 output.extend(input_api.canned_checks.CheckDoNotSubmit(
111 input_api, 112 input_api,
112 output_api)) 113 output_api))
113 output.extend(RunGitClTests(input_api, output_api)) 114 output.extend(RunGitClTests(input_api, output_api))
114 return output 115 return output
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698