Move launching in a job object logic

Move launching in a job object logic
from TestServer to LaunchProcess,
so that I can re-use it in other places
for experiments.

BUG=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100027

[Evan Martin, 2011-09-07 01:42:53]

LGTM

On Tue, Sep 6, 2011 at 5:51 PM,  <phajdan.jr@chromium.org> wrote:
> Reviewers: Evan Martin, cpu,
>
> Description:
> Move launching in a job object logic
> from TestServer to LaunchProcess,
> so that I can re-use it in other places
> for experiments.
>
> BUG=none
>
> Please review this at http://codereview.chromium.org/7789018/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/process_util.h
>  M     base/process_util_win.cc
>  M     net/test/test_server_win.cc
>
>
>

[cpu_(ooo_6.6-7.5), 2011-09-07 20:07:22]

http://codereview.chromium.org/7789018/diff/1/base/process_util_win.cc
File base/process_util_win.cc (right):

http://codereview.chromium.org/7789018/diff/1/base/process_util_win.cc#newcod...
base/process_util_win.cc:244: job_handle.Set(CreateJobObject(NULL, NULL));
so why do we create a job object if there is one already in options?

[Paweł Hajdan Jr., 2011-09-07 20:16:22]

http://codereview.chromium.org/7789018/diff/1/base/process_util_win.cc
File base/process_util_win.cc (right):

http://codereview.chromium.org/7789018/diff/1/base/process_util_win.cc#newcod...
base/process_util_win.cc:244: job_handle.Set(CreateJobObject(NULL, NULL));
On 2011/09/07 20:07:22, cpu wrote:
> so why do we create a job object if there is one already in options?

I create a job object because what's passed in the options is just a pointer to
be filled in.

[cpu_(ooo_6.6-7.5), 2011-09-07 20:24:30]

I feel it is needlessly specific, I think a more generic thing here is the
caller passes the job object with the attributes you want and the function does
the suspend + assign + resume.

[Paweł Hajdan Jr., 2011-09-07 20:36:33]

CL updated. PTAL.

[cpu_(ooo_6.6-7.5), 2011-09-07 21:09:49]

lgtm

http://codereview.chromium.org/7789018/diff/6001/base/process_util_win.cc
File base/process_util_win.cc (right):

http://codereview.chromium.org/7789018/diff/6001/base/process_util_win.cc#new...
base/process_util_win.cc:280: KillProcess(process_info.hProcess, 1, true);
use kProcessKilledExitCode

[Paweł Hajdan Jr., 2011-09-07 21:54:58]

http://codereview.chromium.org/7789018/diff/6001/base/process_util_win.cc
File base/process_util_win.cc (right):

http://codereview.chromium.org/7789018/diff/6001/base/process_util_win.cc#new...
base/process_util_win.cc:280: KillProcess(process_info.hProcess, 1, true);
On 2011/09/07 21:09:49, cpu wrote:
> use kProcessKilledExitCode

Done.