Added an option to append text at the end of the status email n layout test analyzer tool.

Added an option to append text at the end of the status email in layout test analyzer tool.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99805

[imasaki1, 2011-09-06 19:20:32]

Thank you.

[dennis_jeffrey, 2011-09-06 19:25:55]

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer.py (right):

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer.py:86: '(default to %default)'),
You might want to clarify that in the default case, no additional text is
inserted into the e-mail.

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer.py:122: file_object =
open(options.email_insert_text_file_location)
We should check to make sure the file exists before doing this, or else wrap
this code inside a try/except so that the code gracefully handles the case when
we have a problem reading from the input file.

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:277: a file.
nit: indent this line by 1 fewer space

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:279: stored.
nit: indent this line by 1 fewer space

[imasaki1, 2011-09-06 20:26:10]

Thanks. I also did some minor doc change ('insert' -> 'append') to clarify the
behavior.

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer.py (right):

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer.py:86: '(default to %default)'),
On 2011/09/06 19:25:55, dennis_jeffrey wrote:
> You might want to clarify that in the default case, no additional text is
> inserted into the e-mail.

Done.

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer.py:122: file_object =
open(options.email_insert_text_file_location)
On 2011/09/06 19:25:55, dennis_jeffrey wrote:
> We should check to make sure the file exists before doing this, or else wrap
> this code inside a try/except so that the code gracefully handles the case
when
> we have a problem reading from the input file.

Done. Also changed annotation file reading part.

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:277: a file.
On 2011/09/06 19:25:55, dennis_jeffrey wrote:
> nit: indent this line by 1 fewer space

Done.

http://codereview.chromium.org/7789008/diff/1001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:279: stored.
On 2011/09/06 19:25:55, dennis_jeffrey wrote:
> nit: indent this line by 1 fewer space

Done.

[dennis_jeffrey, 2011-09-06 20:34:11]

LGTM

Thank you!