Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 7789004: Update binutils URL and sha1sum for gold sources (Closed)

Created:
9 years, 3 months ago by Roland McGrath
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update binutils URL and sha1sum for gold sources The ftp.gnu.org archive got rebuilt and changed some files in place under the same name but with rebuilt contents. The best binutils source archive that is now available there is the 2.21.1a file, which has a verified .sig (GPG signature) file. BUG= none TEST= none R=bradchen@google.com,bevc@google.com

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix file name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps.sh View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Roland McGrath
9 years, 3 months ago (2011-09-06 18:12:09 UTC) #1
Brad Chen
LGTM
9 years, 3 months ago (2011-09-06 18:30:46 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 3 months ago (2011-09-06 18:31:40 UTC) #3
Lei Zhang
http://codereview.chromium.org/7789004/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): http://codereview.chromium.org/7789004/diff/1/build/install-build-deps.sh#newcode49 build/install-build-deps.sh:49: BINUTILS=binutils-2.21.1a Have you tested this? binutils-2.21.1a.tar.bz2 contains a directory ...
9 years, 3 months ago (2011-09-06 18:35:01 UTC) #4
Roland McGrath
Good catch. I was trying to go with the apparently preferred name of the file ...
9 years, 3 months ago (2011-09-06 18:37:18 UTC) #5
Lei Zhang
LGTM I'd just commit this now instead of waiting for commit-bot.
9 years, 3 months ago (2011-09-06 18:43:09 UTC) #6
Roland McGrath
On 2011/09/06 18:43:09, Lei Zhang wrote: > LGTM > > I'd just commit this now ...
9 years, 3 months ago (2011-09-06 18:51:15 UTC) #7
jam
On 2011/09/06 18:51:15, Roland McGrath wrote: > On 2011/09/06 18:43:09, Lei Zhang wrote: > > ...
9 years, 3 months ago (2011-09-06 18:53:02 UTC) #8
Lei Zhang
On 2011/09/06 18:53:02, John Abd-El-Malek wrote: > On 2011/09/06 18:51:15, Roland McGrath wrote: > > ...
9 years, 3 months ago (2011-09-06 18:58:38 UTC) #9
Brad Chen
I'm working on a CL to revert this change. On Tue, Sep 6, 2011 at ...
9 years, 3 months ago (2011-09-06 18:59:47 UTC) #10
Brad Chen
Clarification: I'm referring to reverting the nacl_helper change, not Roland's fix to the update script. ...
9 years, 3 months ago (2011-09-06 19:00:24 UTC) #11
Lei Zhang
9 years, 3 months ago (2011-09-06 19:00:49 UTC) #12
Roland: Doh. I'll just check it in here: http://codereview.chromium.org/7841002

Powered by Google App Engine
This is Rietveld 408576698