Issue 7789001: Rolling Skia DEPS 2172 -> 2183

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7789001: Rolling Skia DEPS 2172 -> 2183 (Closed)

Created:
9 years, 3 months ago by epoger

Modified:
9 years, 3 months ago

Reviewers:
bsalomon, reed1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Rolling Skia DEPS 2172 -> 2183 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98664

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

epoger

I will update this with a review request once I see all the tests pass...

9 years, 3 months ago (2011-08-29 17:02:52 UTC) #1

epoger

On 2011/08/29 17:02:52, epoger wrote: > I will update this with a review request once ...

9 years, 3 months ago (2011-08-29 17:03:39 UTC) #2

epoger

9 years, 3 months ago (2011-08-29 17:54:27 UTC) #4

On 2011/08/29 17:09:07, reed1 wrote:
> LGTM

All trybots have completed; linux_layout and win_layout were red, while the
others were green.

win_layout completely filed the compile step due to out-of-memory during link,
but win_layout_rel is green... so I think it's OK.

linux_layout was green except for a single cpu-profiler test that crashed with a
segfault. Since linux_layout_rel is green, I think this is OK too.

If I don't hear any shouting in the next 15 minutes I will go ahead and commit
the roll.

Expand Messages | Collapse Messages