Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: src/mips/macro-assembler-mips.cc

Issue 7787028: Use the BitField class for Code::Flags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/ic-mips.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 Branch(miss, ne, key, Operand(at)); 434 Branch(miss, ne, key, Operand(at));
435 } 435 }
436 } 436 }
437 437
438 bind(&done); 438 bind(&done);
439 // Check that the value is a normal property. 439 // Check that the value is a normal property.
440 // reg2: elements + (index * kPointerSize). 440 // reg2: elements + (index * kPointerSize).
441 const int kDetailsOffset = 441 const int kDetailsOffset =
442 NumberDictionary::kElementsStartOffset + 2 * kPointerSize; 442 NumberDictionary::kElementsStartOffset + 2 * kPointerSize;
443 lw(reg1, FieldMemOperand(reg2, kDetailsOffset)); 443 lw(reg1, FieldMemOperand(reg2, kDetailsOffset));
444 And(at, reg1, Operand(Smi::FromInt(PropertyDetails::TypeField::mask()))); 444 And(at, reg1, Operand(Smi::FromInt(PropertyDetails::TypeField::kMask)));
445 Branch(miss, ne, at, Operand(zero_reg)); 445 Branch(miss, ne, at, Operand(zero_reg));
446 446
447 // Get the value at the masked, scaled index and return. 447 // Get the value at the masked, scaled index and return.
448 const int kValueOffset = 448 const int kValueOffset =
449 NumberDictionary::kElementsStartOffset + kPointerSize; 449 NumberDictionary::kElementsStartOffset + kPointerSize;
450 lw(result, FieldMemOperand(reg2, kValueOffset)); 450 lw(result, FieldMemOperand(reg2, kValueOffset));
451 } 451 }
452 452
453 453
454 // --------------------------------------------------------------------------- 454 // ---------------------------------------------------------------------------
(...skipping 3948 matching lines...) Expand 10 before | Expand all | Expand 10 after
4403 opcode == BGTZL); 4403 opcode == BGTZL);
4404 opcode = (cond == eq) ? BEQ : BNE; 4404 opcode = (cond == eq) ? BEQ : BNE;
4405 instr = (instr & ~kOpcodeMask) | opcode; 4405 instr = (instr & ~kOpcodeMask) | opcode;
4406 masm_.emit(instr); 4406 masm_.emit(instr);
4407 } 4407 }
4408 4408
4409 4409
4410 } } // namespace v8::internal 4410 } } // namespace v8::internal
4411 4411
4412 #endif // V8_TARGET_ARCH_MIPS 4412 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/ic-mips.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698