Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 7787014: ntp4: fix positioning of notification bar (Closed)

Created:
9 years, 3 months ago by Evan Stade
Modified:
9 years, 3 months ago
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

ntp4: fix positioning of notification bar also, make it so you can't tab to or click on it when it's not showing BUG=95930 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -17 lines) Patch
M chrome/browser/resources/ntp4/new_tab.css View 1 chunk +14 lines, -11 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 4 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Evan Stade
is there a better way to do this? connecting to webkitTransitionEnd is such a hassle
9 years, 3 months ago (2011-09-08 23:52:44 UTC) #1
arv (Not doing code reviews)
Can you use pointer events and tab index instead of hidden?
9 years, 3 months ago (2011-09-08 23:57:35 UTC) #2
Evan Stade
does tab index affect all children? that would be choice
9 years, 3 months ago (2011-09-08 23:59:39 UTC) #3
Evan Stade
On 2011/09/08 23:59:39, Evan Stade wrote: > does tab index affect all children? that would ...
9 years, 3 months ago (2011-09-09 00:02:38 UTC) #4
Evan Stade
ping
9 years, 3 months ago (2011-09-09 22:13:02 UTC) #5
arv (Not doing code reviews)
LGTM
9 years, 3 months ago (2011-09-09 22:32:08 UTC) #6
Dan Beam
LGTM
9 years, 3 months ago (2011-09-09 22:45:53 UTC) #7
commit-bot: I haz the power
9 years, 3 months ago (2011-09-10 05:25:13 UTC) #8
Change committed as 100568

Powered by Google App Engine
This is Rietveld 408576698