scm.py - Issue 7787008: SVN.GenerateDiff assumes SVN.Capture captures stderr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scm.py

Issue 7787008: SVN.GenerateDiff assumes SVN.Capture captures stderr. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scm.py

diff --git a/scm.py b/scm.py

index 8bd0ba3a61ca3aa667aa224360546ca44e7f4904..9eab39aeccd7639f37cfcbc7bc8d8e357c97a92c 100644

--- a/scm.py

+++ b/scm.py

@@ -397,7 +397,8 @@ class SVN(object):

Throws an exception if non-0 is returned.

"""

- return subprocess2.check_output(['svn'] + args, **kwargs)

+ return subprocess2.check_output(

+ ['svn'] + args, stderr=subprocess2.PIPE, **kwargs)

@staticmethod

def RunAndGetFileList(verbose, args, cwd, file_list, stdout=None):

« no previous file with comments | « no previous file | no next file » | no next file with comments »