Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: chrome/test/data/extensions/api_test/tabs/basics/tabs_util.js

Issue 7787004: Fix crash when calling chrome.tabs.move({index:-1}). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix issue min/max validation Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/data/extensions/api_test/tabs/basics/move.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var fail = chrome.test.callbackFail;
Mihai Parparita -not on Chrome 2011/09/08 20:49:59 Nit: I don't think this change is necessary.
jstritar 2011/09/08 20:54:03 Oops, forgot to get rid of that.
5 var pass = chrome.test.callbackPass; 6 var pass = chrome.test.callbackPass;
6 var assertEq = chrome.test.assertEq; 7 var assertEq = chrome.test.assertEq;
7 var assertTrue = chrome.test.assertTrue; 8 var assertTrue = chrome.test.assertTrue;
8 9
9 function pageUrl(letter) { 10 function pageUrl(letter) {
10 return chrome.extension.getURL(letter + ".html"); 11 return chrome.extension.getURL(letter + ".html");
11 } 12 }
12 13
13 // Creates one window with tabs set to the urls in the array |tabUrls|. 14 // Creates one window with tabs set to the urls in the array |tabUrls|.
14 // At least one url must be specified. 15 // At least one url must be specified.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 break; 48 break;
48 } 49 }
49 if (ready) 50 if (ready)
50 callback(); 51 callback();
51 else 52 else
52 window.setTimeout(waitForTabs, 30); 53 window.setTimeout(waitForTabs, 30);
53 }); 54 });
54 } 55 }
55 waitForTabs(); 56 waitForTabs();
56 } 57 }
OLDNEW
« no previous file with comments | « chrome/test/data/extensions/api_test/tabs/basics/move.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698