Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 7786001: Fixed issue v8:1644 (bug in the chaining of fixup position) (Closed)

Created:
9 years, 3 months ago by Sven Panne
Modified:
9 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fixed a bug in the chaining of fixup position The ARM and MIPS assemblers had a bug where they did not handle the last element in the list of code positions correctly during the fixup of offsets for forward jumps. This happened when the first instruction contained a forward jump to a label, and that label was used in a forward jump later, too. Unified the code for Assembler::next on ARM and MIPS while we were there. Added test cases, even for ia32/x64, which seem to be correct, even I don't fully understand why... %-} BUG=v8:1644 Committed: http://code.google.com/p/v8/source/detail?r=9063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -6 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
9 years, 3 months ago (2011-08-29 15:17:33 UTC) #1
Jakob Kummerow
9 years, 3 months ago (2011-08-29 15:30:38 UTC) #2
LGTM.

Please add a line "BUG=v8:1644" to the CL description to get auto-linking
goodness :-)

Powered by Google App Engine
This is Rietveld 408576698