Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 7785026: Fixed update mechanism for the file manager preview. (Closed)

Created:
9 years, 3 months ago by SeRya
Modified:
9 years, 3 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Fixed update mechanism for the file manager preview. The preview pane lined to the focused item in the file list. However was updated on update selection and disappeared when the selection gets empty (it happens when the user clicks on the checkbox of a single selected item). There is a way to move focus (it's calls 'a lead item' internally) without changing selection (using ctrl+arrows). BUG=chromium-os:18211 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98985

Patch Set 1 : Style fixes. #

Patch Set 2 : Missed semicolon. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -26 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 12 chunks +41 lines, -26 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
SeRya
Please, review.
9 years, 3 months ago (2011-08-31 12:53:24 UTC) #1
Dmitry Zvorygin
On 2011/08/31 12:53:24, SeRya wrote: > Please, review. LGTM
9 years, 3 months ago (2011-08-31 15:07:52 UTC) #2
commit-bot: I haz the power
Change committed as 98985
9 years, 3 months ago (2011-08-31 16:39:05 UTC) #3
rginda
9 years, 3 months ago (2011-08-31 18:04:12 UTC) #4
I think this would have been a much less invasive change if we just updated the
selection when the lead item changed.

http://codereview.chromium.org/7785026/diff/6002/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/7785026/diff/6002/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/file_manager.js:2041: } else {
else after return.

http://codereview.chromium.org/7785026/diff/6002/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/file_manager.js:3038: var leadEntry =
this.getLeadEntry();
If you have some items selected and press enter, it's going to change directory
as long as the lead item is a directory.

We should test that selection.totalLength == 0, or that totalLength == 1 and the
selected item is the lead item, except that sounds like a mess :/

Powered by Google App Engine
This is Rietveld 408576698