Issue 7785025: Add tools/presubmit.py call to tools/test-wrapper-gypbuild.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7785025: Add tools/presubmit.py call to tools/test-wrapper-gypbuild.py (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow

Modified:
9 years, 3 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add tools/presubmit.py call to tools/test-wrapper-gypbuild.py Committed: http://code.google.com/p/v8/source/detail?r=9081

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	Makefile	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	tools/test-wrapper-gypbuild.py	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2011/08/31 10:10:49, Jakob wrote: > PTAL. LGTM. Something to consider: more visible warning or ...

9 years, 3 months ago (2011-08-31 11:24:03 UTC) #2

Jakob Kummerow

9 years, 3 months ago (2011-08-31 13:01:06 UTC) #3

> Something to consider: more visible warning or even abort testing if style
> errors are found during presubmit test.

I'd prefer not to do that, because the presubmit script returns failure even
when you've got a local test-whatever.js file lying around that doesn't contain
a copyright header. So we'd have to modify presubmit.py first.

Landing.

Expand Messages | Collapse Messages