Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7785007: Added talkgadget blank page to trampoline triggers, pending server config changes. (Closed)

Created:
9 years, 3 months ago by Jamie
Modified:
9 years, 3 months ago
Reviewers:
simonmorris
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Added talkgadget blank page to trampoline triggers, pending server config changes. BUG=None TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98891

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added ?* wildcarded version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M remoting/webapp/me2mom/manifest.json View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jamie
PTAL.
9 years, 3 months ago (2011-08-30 20:34:11 UTC) #1
simonmorris
http://codereview.chromium.org/7785007/diff/1/remoting/webapp/me2mom/manifest.json File remoting/webapp/me2mom/manifest.json (right): http://codereview.chromium.org/7785007/diff/1/remoting/webapp/me2mom/manifest.json#newcode20 remoting/webapp/me2mom/manifest.json:20: "https://talkgadget.google.com/talkgadget/blank" No "...talkgadget/blank?*" entry?
9 years, 3 months ago (2011-08-30 20:47:06 UTC) #2
Jamie
http://codereview.chromium.org/7785007/diff/1/remoting/webapp/me2mom/manifest.json File remoting/webapp/me2mom/manifest.json (right): http://codereview.chromium.org/7785007/diff/1/remoting/webapp/me2mom/manifest.json#newcode20 remoting/webapp/me2mom/manifest.json:20: "https://talkgadget.google.com/talkgadget/blank" On 2011/08/30 20:47:06, simonmorris wrote: > No "...talkgadget/blank?*" ...
9 years, 3 months ago (2011-08-30 20:55:53 UTC) #3
simonmorris
9 years, 3 months ago (2011-08-30 22:33:04 UTC) #4 
On 2011/08/30 20:55:53, Jamie wrote:
>
http://codereview.chromium.org/7785007/diff/1/remoting/webapp/me2mom/manifest...
> File remoting/webapp/me2mom/manifest.json (right):
> 
>
http://codereview.chromium.org/7785007/diff/1/remoting/webapp/me2mom/manifest...
> remoting/webapp/me2mom/manifest.json:20:
> "https://talkgadget.google.com/talkgadget/blank"
> On 2011/08/30 20:47:06, simonmorris wrote:
> > No "...talkgadget/blank?*" entry?
> 
> Good catch!

LGTM

Powered by Google App Engine
This is Rietveld 408576698