Issue 7785003: Fix crash in AudioFileReader::Read() by checking for properly initialized AVCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7785003: Fix crash in AudioFileReader::Read() by checking for properly initialized AVCodec (Closed)

Created:
9 years, 3 months ago by Chris Rogers

Modified:
9 years, 3 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix crash in AudioFileReader::Read() by checking for properly initialized AVCodec Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98863

Patch Set 1 #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	media/filters/audio_file_reader.cc	View		2 chunks	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Rogers

This fixes crasher: http://code.google.com/p/chromium/issues/detail?id=88131 When trying to read some audio files not supported by FFmpeg ...

9 years, 3 months ago (2011-08-30 19:31:59 UTC) #1

scherkus (not reviewing)

9 years, 3 months ago (2011-08-30 20:25:33 UTC) #3

http://codereview.chromium.org/7785003/diff/1/media/filters/audio_file_reader.cc
File media/filters/audio_file_reader.cc (right):

http://codereview.chromium.org/7785003/diff/1/media/filters/audio_file_reader...
media/filters/audio_file_reader.cc:95: DLOG(WARNING) << "AudioFileReader::Open()
: could not find codec -"
the indentation is wrong here -- could you TBR a patch fixing this?

Expand Messages | Collapse Messages