Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 7785001: Return v8::True or v8::False instead of using Boolean::New. (Closed)

Created:
9 years, 3 months ago by tfarina
Modified:
9 years, 3 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Return v8::True or v8::False instead of using Boolean::New. BUG=None TEST=None R=mnaganov@chromium.org Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: http://code.google.com/p/v8/source/detail?r=9073

Patch Set 1 #

Total comments: 2

Patch Set 2 : mnaganov review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/d8.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 4 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
9 years, 3 months ago (2011-08-29 15:14:41 UTC) #1
mnaganov (inactive)
LGTM, with one comment. What do you think about this? You are not going to ...
9 years, 3 months ago (2011-08-30 10:36:59 UTC) #2
tfarina
9 years, 3 months ago (2011-08-30 18:28:23 UTC) #3
http://codereview.chromium.org/7785001/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/7785001/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:9570: return args.IsConstructCall() ? v8::True() :
v8::False();
On 2011/08/30 10:37:00, Mikhail Naganov (Chromium) wrote:
> I believe, return v8::Boolean::New(args.IsConstructCall()) is more concise,
and
> this is the case where v8::Boolean::New is useful.

Done.

Powered by Google App Engine
This is Rietveld 408576698