Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

Issue 7784003: [cros] User image selection wraps when navigating with arrow keys. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
diff --git a/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js b/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
index 4b15dcd17ec8abba4ffdbe64fc323cbf320956bc..bf52557127b8f103ac3ac87f487a744827ca1e47 100644
--- a/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
+++ b/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
@@ -125,13 +125,10 @@ cr.define('oobe', function() {
userImageList.addEventListener('keydown', function(e) {
var prevIndex = userImageScreen.selectedUserImage_;
var len = userImageList.children.length;
- if (e.keyCode == 39 || e.keyCode == 40) { // right or down
- if (prevIndex < len - 1)
- UserImageScreen.selectUserImage(prevIndex + 1);
- } else if (e.keyCode == 37 || e.keyCode == 38) { // left or up
- if (prevIndex > 0)
- UserImageScreen.selectUserImage(prevIndex - 1);
- }
+ if (e.keyCode == 39 || e.keyCode == 40) // right or down
+ UserImageScreen.selectUserImage((prevIndex + 1) % len);
+ else if (e.keyCode == 37 || e.keyCode == 38) // left or up
+ UserImageScreen.selectUserImage((prevIndex - 1 + len) % len);
e.stopPropagation();
});
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698