Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

Issue 7784003: [cros] User image selection wraps when navigating with arrow keys. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Oobe user image screen implementation. 6 * @fileoverview Oobe user image screen implementation.
7 */ 7 */
8 8
9 cr.define('oobe', function() { 9 cr.define('oobe', function() {
10 /** 10 /**
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 UserImageScreen.addUserImage( 118 UserImageScreen.addUserImage(
119 imageUrl, 119 imageUrl,
120 UserImageScreen.handleImageClick); 120 UserImageScreen.handleImageClick);
121 } 121 }
122 122
123 var userImageScreen = $('user-image'); 123 var userImageScreen = $('user-image');
124 var userImageList = $('user-image-list'); 124 var userImageList = $('user-image-list');
125 userImageList.addEventListener('keydown', function(e) { 125 userImageList.addEventListener('keydown', function(e) {
126 var prevIndex = userImageScreen.selectedUserImage_; 126 var prevIndex = userImageScreen.selectedUserImage_;
127 var len = userImageList.children.length; 127 var len = userImageList.children.length;
128 if (e.keyCode == 39 || e.keyCode == 40) { // right or down 128 if (e.keyCode == 39 || e.keyCode == 40) // right or down
129 if (prevIndex < len - 1) 129 UserImageScreen.selectUserImage((prevIndex + 1) % len);
130 UserImageScreen.selectUserImage(prevIndex + 1); 130 else if (e.keyCode == 37 || e.keyCode == 38) // left or up
131 } else if (e.keyCode == 37 || e.keyCode == 38) { // left or up 131 UserImageScreen.selectUserImage((prevIndex - 1 + len) % len);
132 if (prevIndex > 0)
133 UserImageScreen.selectUserImage(prevIndex - 1);
134 }
135 e.stopPropagation(); 132 e.stopPropagation();
136 }); 133 });
137 }; 134 };
138 135
139 /** 136 /**
140 * Selects the specified user image and shows it in preview. 137 * Selects the specified user image and shows it in preview.
141 * @param {number} index The index of the image to select. 138 * @param {number} index The index of the image to select.
142 */ 139 */
143 UserImageScreen.selectUserImage = function(index) { 140 UserImageScreen.selectUserImage = function(index) {
144 var userImageList = $('user-image-list'); 141 var userImageList = $('user-image-list');
(...skipping 10 matching lines...) Expand all
155 selectedImage.focus(); 152 selectedImage.focus();
156 $('user-image-preview').src = selectedImage.src; 153 $('user-image-preview').src = selectedImage.src;
157 } 154 }
158 userImageScreen.selectedUserImage_ = index; 155 userImageScreen.selectedUserImage_ = index;
159 }; 156 };
160 157
161 return { 158 return {
162 UserImageScreen: UserImageScreen 159 UserImageScreen: UserImageScreen
163 }; 160 };
164 }); 161 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698