Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 7782040: Merge 94102 - [Chromium] Add null checks for document()->loader() (Closed)

Created:
9 years, 3 months ago by abarth-chromium
Modified:
9 years, 3 months ago
Reviewers:
abarth
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

Merge 94102 - [Chromium] Add null checks for document()->loader() https://bugs.webkit.org/show_bug.cgi?id=67077 Reviewed by Nate Chapin. Document::loader can return 0 for a number of reasons. Call sites need to null check the result, like we do for Document::frame. I suspect some of these are real crashes, along the lines of http://trac.webkit.org/changeset/93692, but null checking this function is just good practice. * src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): * src/WebSearchableFormData.cpp: (HTMLNames::GetFormEncoding): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding): TBR=abarth@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/WebKit/chromium/src/ContextMenuClientImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebSearchableFormData.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
abarth-chromium
9 years, 3 months ago (2011-09-07 21:09:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698