Switch from chrome://extensions to chrome://settings/extensionSettings.

Switch from chrome://extensions to chrome://settings/extensionSettings.

BUG=87377
TEST=All links that went to chrome://extensions (from the wrench menu/extension action context menu etc) should go to the new settings page.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100893

[Finnur, 2011-09-08 11:40:57]

http://codereview.chromium.org/7782026/diff/8001/chrome/browser/resources/opt...
File chrome/browser/resources/options/extension_settings.js (right):

http://codereview.chromium.org/7782026/diff/8001/chrome/browser/resources/opt...
chrome/browser/resources/options/extension_settings.js:7: var webui_responded_ =
false;
The download test uses this (it was in the old chrome://extensions page).

[Evan Stade, 2011-09-08 16:27:44]

http://codereview.chromium.org/7782026/diff/8001/chrome/browser/download/down...
File chrome/browser/download/download_browsertest.cc (right):

http://codereview.chromium.org/7782026/diff/8001/chrome/browser/download/down...
chrome/browser/download/download_browsertest.cc:1503: GURL
extensions_url(GURL(chrome::kChromeUISettingsURL).Resolve(
is there some reason to use Resolve over simple string concatenation? It seems a
bit overkill.

[Finnur, 2011-09-08 16:51:19]

Yeah, I guess that's true...

[jennb, 2011-09-08 17:24:26]

Drive by...

http://codereview.chromium.org/7782026/diff/11003/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_browsertests_misc.cc (right):

http://codereview.chromium.org/7782026/diff/11003/chrome/browser/extensions/e...
chrome/browser/extensions/extension_browsertests_misc.cc:828: // Go to the
chrome://extensions page and click the Options button.
Update comment with new URL.

[Aaron Boodman, 2011-09-08 18:09:49]

Does this redirect chrome://extensions/ to the new URL someplace? That would be
swell. Lots of muscle memory built up over the years. I'm sure users are dong
this too. We have lots of blog posts and mailing list entries that tell people
to type 'chrome://extensions/'.

[Finnur, 2011-09-08 18:48:16]

It does not redirect to the new URL at the moment, but I plan to do so. The
reason it doesn't is twofold:

1) There are two tests that can't yet be switched to use the new Settings page.
2) I'm pondering the best way to issue the redirect.

I'm currently investigating both of those.

http://codereview.chromium.org/7782026/diff/11003/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_browsertests_misc.cc (right):

http://codereview.chromium.org/7782026/diff/11003/chrome/browser/extensions/e...
chrome/browser/extensions/extension_browsertests_misc.cc:828: // Go to the
chrome://extensions page and click the Options button.
On 2011/09/08 17:24:27, jennb wrote:
> Update comment with new URL.

Done.

[Evan Stade, 2011-09-08 19:05:47]

msw might have some insight into best way to do the redirect

[msw, 2011-09-08 20:06:26]

On 2011/09/08 19:05:47, Evan Stade wrote:
> msw might have some insight into best way to do the redirect

Several chrome host redirects are in WillHandleBrowserAboutURL.
See chrome/browser/browser_about_handler.cc

[jianli, 2011-09-08 23:07:16]

I've moved ExecuteCommand from PanelBrowserFrameView to
PanelSettingsMenulModel in a patch just landed. Please remember to resync
and merge your change over. Thanks.

On Thu, Sep 8, 2011 at 1:06 PM, <msw@chromium.org> wrote:

> On 2011/09/08 19:05:47, Evan Stade wrote:
>
>> msw might have some insight into best way to do the redirect
>>
>
> Several chrome host redirects are in WillHandleBrowserAboutURL.
> See chrome/browser/browser_about_**handler.cc
>
>
>
http://codereview.chromium.**org/7782026/<http://codereview.chromium.org/7782...
>

[Finnur, 2011-09-08 23:35:38]

Thanks for the heads up!

[Finnur, 2011-09-09 00:00:15]

Updated to reflect this.

[Finnur, 2011-09-10 11:14:07]

On 2011/09/09 00:00:15, Finnur wrote:
> Updated to reflect this.

Aaron, ping?

[Aaron Boodman, 2011-09-12 19:10:09]

Sorry, I thought estade was reviewing. The change looks fine, but I still don't
see the redirect that msw suggested how to implement.

[Evan Stade, 2011-09-12 19:59:36]

sorry, I should have specified it was a drive-by

[Finnur, 2011-09-13 09:57:00]

Scott, looks like the minor one-line change to the test triggers an owner's LG,
can you provide it?

[Finnur, 2011-09-13 09:57:24]

(It's the file at the bottom of the list above)

[Finnur, 2011-09-13 10:34:06]

On 2011/09/12 19:10:09, Aaron Boodman wrote:
> Sorry, I thought estade was reviewing. The change looks fine, but I still
don't
> see the redirect that msw suggested how to implement.

And yes, that was intentional. I have that change in my local tree and it is
working, but two tests fail when we switch over from the old page to the new
page automatically. Need to look into those.

[sky, 2011-09-13 17:50:03]

lgtm