Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 7782023: Reintroduce duplicate identifier detection in preparser. (Closed)

Created:
9 years, 3 months ago by Lasse Reichstein
Modified:
9 years, 3 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Reintroduce duplicate identifier detection in preparser. Duplicate identifier detection must be an early syntax error in strict code, so errors in otherwise lazily compiled functions must be caught in the preparser. Originally introduced in r8541 and reverted in r8542. Now really compiles on Windows. Committed: http://code.google.com/p/v8/source/detail?r=9172

Patch Set 1 #

Patch Set 2 : Added files to gyp #

Patch Set 3 : Removed dependency on platform.h in conversions-inl.h #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+903 lines, -194 lines) Patch
M src/SConscript View 2 chunks +12 lines, -2 lines 0 comments Download
M src/bignum-dtoa.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/conversions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/conversions.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M src/conversions-inl.h View 1 2 3 chunks +11 lines, -6 lines 0 comments Download
M src/dtoa.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/fast-dtoa.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/fixed-dtoa.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/globals.h View 1 2 1 chunk +29 lines, -0 lines 2 comments Download
M src/platform.h View 1 2 3 chunks +17 lines, -52 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +1 line, -69 lines 0 comments Download
M src/preparser.h View 4 chunks +97 lines, -0 lines 0 comments Download
M src/preparser.cc View 21 chunks +222 lines, -33 lines 0 comments Download
M src/preparser-api.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/scanner-base.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/strtod.cc View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M src/utils.h View 2 chunks +15 lines, -10 lines 0 comments Download
A src/win32-math.h View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A src/win32-math.cc View 1 chunk +106 lines, -0 lines 0 comments Download
A test/preparser/duplicate-parameter.pyt View 1 chunk +90 lines, -0 lines 0 comments Download
A test/preparser/duplicate-property.pyt View 1 chunk +162 lines, -0 lines 0 comments Download
M test/preparser/testcfg.py View 3 chunks +2 lines, -4 lines 0 comments Download
M tools/gyp/v8.gyp View 1 3 chunks +46 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein
9 years, 3 months ago (2011-09-07 07:03:31 UTC) #1
Rico
LGTM (as discussed offline, this is very similar to 8541 except code moved from platform.h ...
9 years, 3 months ago (2011-09-07 07:39:05 UTC) #2
Rico
Still LGTM http://codereview.chromium.org/7782023/diff/3003/src/globals.h File src/globals.h (right): http://codereview.chromium.org/7782023/diff/3003/src/globals.h#newcode45 src/globals.h:45: #if __GNUC_VERSION_FOR_INFTY__ >= 29600 && __GNUC_VERSION_FOR_INFTY__ < ...
9 years, 3 months ago (2011-09-07 11:51:31 UTC) #3
Lasse Reichstein
9 years, 3 months ago (2011-09-07 11:59:14 UTC) #4
http://codereview.chromium.org/7782023/diff/3003/src/globals.h
File src/globals.h (right):

http://codereview.chromium.org/7782023/diff/3003/src/globals.h#newcode45
src/globals.h:45: #if __GNUC_VERSION_FOR_INFTY__ >= 29600 &&
__GNUC_VERSION_FOR_INFTY__ < 40100
We probably could, but I'd say that's an executive decision :)

Powered by Google App Engine
This is Rietveld 408576698