Issue 7781004: Move Speak() in accessibility_utils, speak enable and disable strings when

Issue 7781004: Move Speak() in accessibility_utils, speak enable and disable strings when (Closed)

Created:
9 years, 3 months ago by Zachary Kuznia

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, dmazzoni, hashimoto

CC:
chromium-reviews, nkostylev+cc_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move Speak() in accessibility_utils, speak enable and disable strings when accessibility state changes BUG=chromium-os:19647 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98921

Patch Set 1 #

Patch Set 2 : Code Review #

Total comments: 4

Patch Set 3 : Remove the extra speaking. #

Patch Set 4 : Remove unused headers #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -32 lines)			Patch
M	chrome/browser/chromeos/accessibility_util.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/accessibility_util.cc	View	1 2	4 chunks	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_accessibility_handler.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_accessibility_handler.cc	View	1 2 3	2 chunks	+2 lines, -21 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_accessibility_helper.cc	View	1 2	2 chunks	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Zachary Kuznia

On 2011/08/29 08:54:07, Zachary Kuznia wrote: This CL leaves two issues: -The first string sent ...

9 years, 3 months ago (2011-08-29 08:56:37 UTC) #2

hashimoto

http://codereview.chromium.org/7781004/diff/7/chrome/browser/chromeos/login/wizard_accessibility_helper.cc File chrome/browser/chromeos/login/wizard_accessibility_helper.cc (right): http://codereview.chromium.org/7781004/diff/7/chrome/browser/chromeos/login/wizard_accessibility_helper.cc#newcode119 chrome/browser/chromeos/login/wizard_accessibility_helper.cc:119: false, true); This code will speak the message twice ...

9 years, 3 months ago (2011-08-29 09:41:56 UTC) #3

dmazzoni

LGTM. http://codereview.chromium.org/7781004/diff/7/chrome/browser/chromeos/login/wizard_accessibility_handler.cc File chrome/browser/chromeos/login/wizard_accessibility_handler.cc (right): http://codereview.chromium.org/7781004/diff/7/chrome/browser/chromeos/login/wizard_accessibility_handler.cc#newcode15 chrome/browser/chromeos/login/wizard_accessibility_handler.cc:15: #include "chrome/browser/chromeos/cros/cros_library.h" I think you can delete this, ...

9 years, 3 months ago (2011-08-29 22:30:02 UTC) #4

Zachary Kuznia

http://codereview.chromium.org/7781004/diff/7/chrome/browser/chromeos/login/wizard_accessibility_handler.cc File chrome/browser/chromeos/login/wizard_accessibility_handler.cc (right): http://codereview.chromium.org/7781004/diff/7/chrome/browser/chromeos/login/wizard_accessibility_handler.cc#newcode15 chrome/browser/chromeos/login/wizard_accessibility_handler.cc:15: #include "chrome/browser/chromeos/cros/cros_library.h" On 2011/08/29 22:30:03, Dominic Mazzoni wrote: > ...

9 years, 3 months ago (2011-08-30 08:03:36 UTC) #5

Change committed as 98921

Expand Messages | Collapse Messages