Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 778005: Optimize fromCharCode for smi argument(s) case. (Closed)

Created:
10 years, 9 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Optimize fromCharCode for smi argument(s) case.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/string.js View 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Small review. Measureable speedups, but a few regressions as well. Please check and discuss.
10 years, 9 months ago (2010-03-10 08:20:55 UTC) #1
Erik Corry
10 years, 9 months ago (2010-03-10 10:30:24 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698