Chromium Code Reviews Chromium Code Reviews
Issue 7780032:
Fix some valgrind errors in d8 shell. (Closed)
Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/| Index: src/d8.cc |
| =================================================================== |
| --- src/d8.cc (revision 9206) |
| +++ src/d8.cc (working copy) |
| @@ -1076,6 +1076,12 @@ |
| } |
| +ShellOptions::~ShellOptions() { |
|
Vitaly Repeshko
2011/09/12 22:06:09
nit: To match the order in the .h file this should
fschneider
2011/09/13 09:29:24
Done.
|
| + delete[] isolate_sources; |
| + isolate_sources = NULL; |
|
Vitaly Repeshko
2011/09/12 22:06:09
Looks like parallel_files should be deleted as wel
fschneider
2011/09/13 09:29:24
Done.
|
| +} |
| + |
| + |
| void SourceGroup::WaitForThread() { |
| if (thread_ == NULL) return; |
| if (Shell::options.last_run) { |
| @@ -1195,7 +1201,7 @@ |
| v8::V8::SetFlagsFromCommandLine(&argc, argv, true); |
| - // set up isolated source groups |
| + // Set up isolated source groups. |
| options.isolate_sources = new SourceGroup[options.num_isolates]; |
| SourceGroup* current = options.isolate_sources; |
| current->Begin(argv, 1); |
