Fix some valgrind errors in d8 shell.

src/d8.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1058 matching lines @@
 
 void SourceGroup::StartExecuteInThread() {
   if (thread_ == NULL) {
     thread_ = new IsolateThread(this);
     thread_->Start();
   }
   next_semaphore_->Signal();
 }
 
 
+ShellOptions::~ShellOptions() {

[Vitaly Repeshko, 2011/09/12 22:06:09]

nit: To match the order in the .h file this should after the next function.

[fschneider, 2011/09/13 09:29:24]

Done.

+  delete[] isolate_sources;
+  isolate_sources = NULL;

[Vitaly Repeshko, 2011/09/12 22:06:09]

Looks like parallel_files should be deleted as well (when not V8_SHARED).

[fschneider, 2011/09/13 09:29:24]

Done.

+}
+
+
 void SourceGroup::WaitForThread() {
   if (thread_ == NULL) return;
   if (Shell::options.last_run) {
     thread_->Join();
   } else {
     done_semaphore_->Wait();
   }
 }
 #endif  // V8_SHARED
 
@@ skipping 99 matching lines @@
       }
       argv[i] = NULL;
       options.parallel_files->Add(i::Vector<const char>(files, size));
       delete[] files;
     }
   }
 #endif  // V8_SHARED
 
   v8::V8::SetFlagsFromCommandLine(&argc, argv, true);
 
-  // set up isolated source groups
+  // Set up isolated source groups.
   options.isolate_sources = new SourceGroup[options.num_isolates];
   SourceGroup* current = options.isolate_sources;
   current->Begin(argv, 1);
   for (int i = 1; i < argc; i++) {
     const char* str = argv[i];
     if (strcmp(str, "--isolate") == 0) {
       current->End(i);
       current++;
       current->Begin(argv, i + 1);
     } else if (strncmp(argv[i], "--", 2) == 0) {
@@ skipping 116 matching lines @@
 }
 
 }  // namespace v8
 
 
 #ifndef GOOGLE3
 int main(int argc, char* argv[]) {
   return v8::Shell::Main(argc, argv);
 }
 #endif