Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 7780032: Fix some valgrind errors in d8 shell. (Closed)

Created:
9 years, 3 months ago by fschneider
Modified:
9 years, 3 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Fix some valgrind errors in d8 shell. This fixes 3 possibly lost warnings occurring when running unit tests under d8: 28 bytes in 1 blocks are possibly lost in loss record 40 of 68 at 0x67FB8DB: operator new[](unsigned int) by 0x83865CC: v8::Shell::SetOptions(int, char**) (d8.cc:1200) by 0x83869A5: v8::Shell::Main(int, char**) (d8.cc:1276) by 0x8386B31: main (d8.cc:1333) Committed: http://code.google.com/p/v8/source/detail?r=9252

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/d8.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/d8.cc View 2 chunks +7 lines, -1 line 4 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
9 years, 3 months ago (2011-09-12 09:36:32 UTC) #1
Vitaly Repeshko
LGTM http://codereview.chromium.org/7780032/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7780032/diff/1/src/d8.cc#newcode1079 src/d8.cc:1079: ShellOptions::~ShellOptions() { nit: To match the order in ...
9 years, 3 months ago (2011-09-12 22:06:09 UTC) #2
fschneider
9 years, 3 months ago (2011-09-13 09:29:24 UTC) #3
http://codereview.chromium.org/7780032/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/7780032/diff/1/src/d8.cc#newcode1079
src/d8.cc:1079: ShellOptions::~ShellOptions() {
On 2011/09/12 22:06:09, Vitaly Repeshko wrote:
> nit: To match the order in the .h file this should after the next function.

Done.

http://codereview.chromium.org/7780032/diff/1/src/d8.cc#newcode1081
src/d8.cc:1081: isolate_sources = NULL;
On 2011/09/12 22:06:09, Vitaly Repeshko wrote:
> Looks like parallel_files should be deleted as well (when not V8_SHARED).

Done.

Powered by Google App Engine
This is Rietveld 408576698