Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 7780031: Fix sync test crashing when multiprofiles are enabled on Mac. (Closed)

Created:
9 years, 3 months ago by Miranda Callahan
Modified:
9 years, 3 months ago
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, achuith+watch_chromium.org, rginda+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Fix sync test crashing when multiprofiles are enabled on Mac. (This is basically http://codereview.chromium.org/7621066/, except using my correct chromium token to upload.) TBR=rsimha@chromium.org (Already have your LGTM on the original patch!) BUG=93278 TEST=sync_integration_tests all work fine when multiprofiles are enabled by default. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100926

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M chrome/browser/profiles/profile_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Miranda Callahan
Oh, I included turning on multiprofiles for mac in this CL -- I can remove ...
9 years, 3 months ago (2011-09-12 11:13:52 UTC) #1
Robert Sesek
On 2011/09/12 11:13:52, Miranda Callahan wrote: > Oh, I included turning on multiprofiles for mac ...
9 years, 3 months ago (2011-09-12 14:02:16 UTC) #2
Miranda Callahan
On 2011/09/12 14:02:16, rsesek wrote: > On 2011/09/12 11:13:52, Miranda Callahan wrote: > > Oh, ...
9 years, 3 months ago (2011-09-12 14:09:43 UTC) #3
Robert Sesek
LGTM. Thanks!
9 years, 3 months ago (2011-09-12 14:12:09 UTC) #4
commit-bot: I haz the power
Presubmit check for 7780031-4001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 3 months ago (2011-09-13 07:04:48 UTC) #5
commit-bot: I haz the power
Presubmit check for 7780031-4001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 3 months ago (2011-09-13 08:20:06 UTC) #6
commit-bot: I haz the power
9 years, 3 months ago (2011-09-13 16:40:07 UTC) #7
Change committed as 100926

Powered by Google App Engine
This is Rietveld 408576698