First step into enabling pure views build for Chromium/ChromiumOS

build/common.gypi

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
   'variables': {
     # Putting a variables dict inside another variables dict looks kind of
     # weird.  This is done so that 'host_arch', 'chromeos', etc are defined as
     # variables within the outer variables dict here.  This is necessary
     # to get these variables defined for the conditions within this variables
     # dict that operate on these variables (e.g., for setting 'toolkit_views',
     # we need to have 'chromeos' already set).
     'variables': {
       'variables': {
         'variables': {
           # Whether we're building a ChromeOS build.
           'chromeos%': 0,
 
           # Whether the Views toolkit can use its Pure form when available
           # or if it must only use GTK (the default at the moment).
           # This is an intermediate step until all of Views is 'Pure',
           # at which point we plan to remove those switches.
-          # This turns on the TOOLKIT_USES_PURE_VIEWS macro which is used
-          # to replace the corresponding GTK implementation in such a way
-          # that GTK and PureViews can coexist. This intermediate solution
-          # allow us to switch the view implementations using
-          # --use-pure-views, without breaking exiting gtk implementation.
+          # This turns on the TOOLKIT_USES_PURE_VIEWS macro.
           'toolkit_uses_pure_views%': 0,
 
           # Disable touch support by default.
           'touchui%': 0,
 
           # Disable webui dialog replacements for native dialogs by default.
           # TODO(flackr): Change this to a runtime flag triggered by
           #     --pure-views so that these dialogs can be easily tested. 
           'webui_dialogs%': 0,
 
@@ skipping 16 matching lines @@
           [ 'OS=="win" or OS=="mac"', {
             'host_arch%': 'ia32',
           }, {
             # This handles the Unix platforms for which there is some support.
             # Anything else gets passed through, which probably won't work very
             # well; such hosts should pass an explicit target_arch to gyp.
             'host_arch%':
               '<!(uname -m | sed -e "s/i.86/ia32/;s/x86_64/x64/;s/amd64/x64/;s/arm.*/arm/;s/i86pc/ia32/")',
           }],
 
-          # Set default value of toolkit_views on for Windows, Chrome OS
-          # and the touch UI.
+          # Set default value of toolkit_views on for Windows, Chrome OS,
+          # Touch and PureView.
           ['OS=="win" or chromeos==1 or touchui==1 or toolkit_uses_pure_views==1', {
             'toolkit_views%': 1,
           }, {
             'toolkit_views%': 0,
           }],
 
-          # Views are always Pure in Touch case
+          # Views are always Pure in Touch case.
           ['touchui==1', {
             'toolkit_uses_pure_views%': 1,
           }, {
             'toolkit_uses_pure_views%': 0,
           }],
 
-          # Use WebUI dialogs in TouchUI builds.
-          ['touchui==1', {
+          # Use WebUI dialogs in TouchUI and PureView builds.
+          ['touchui==1 or toolkit_uses_pure_views==1', {
             'webui_dialogs%': 1,

[oshima, 2011/09/10 02:04:19]

just a q: do you know when we'll make this a flag?

[Emmanuel Saint-loubert-Bié, 2011/09/10 03:06:31]

I assume when rbyers / flackr are further along?

           }],
-          
+
           # Use the views compositor when using the Aura window manager.
           ['use_aura==1', {
             'views_compositor%': 1,
           }],
         ],
       },
 
       # Copy conditionally-set variables out one scope.
       'chromeos%': '<(chromeos)',
       'touchui%': '<(touchui)',
@@ skipping 163 matching lines @@
         }, {
           'enable_flapper_hacks%': 0,
         }],
 
         # Enable file manager extension by default on Chrome OS.
         ['chromeos==1', {
           'file_manager_extension%': 1,
         }, {
           'file_manager_extension%': 0,
         }],
-        
-        # Enable WebUI TaskManager only on Chrome OS and Touch UI.
-        ['chromeos==1 or touchui==1', {
+
+        # Enable WebUI TaskManager only on Chrome OS, Touch or PureView.
+        ['chromeos==1 or touchui==1 or toolkit_uses_pure_views==1', {
           'webui_task_manager%': 1,
         }, {
           'webui_task_manager%': 0,
         }],
 
         # Enable smooth scrolling for Mac, Win, Linux and ChromeOS
         ['OS=="linux" or OS=="mac" or OS=="win"', {
           'enable_smooth_scrolling%': 1,
         }, {
           'enable_smooth_scrolling%': 0,
@@ skipping 1767 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }