First step into enabling pure views build for Chromium/ChromiumOS

Up to now the only touch UI was running Pure Views. However, we want to improve Pure Views for Chromium and ChromiumOS benefit independently of Touch. And therefore make the "use_only_pure_views" orthogonal so that it can be enabled with chromeos==0 or ==1 and/or with touchui==0.

The ultimate goal is to have toolkit_views <==> use_only_pure_views when all the GTK code has been removed from Views.

Note: as a side-effect this should  reduce the need to use #ifdef TOUCH_UI which in many cases shall be replaced by USE_ONLY_PURE_VIEWS.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100846

[Emmanuel Saint-loubert-Bié, 2011-09-10 00:54:12]

As discussed this will enable us to just set toolkit_uses_pure_views in builds.

[oshima, 2011-09-10 02:04:19]

http://codereview.chromium.org/7780012/diff/3003/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7780012/diff/3003/build/common.gypi#newcode82
build/common.gypi:82: 'webui_dialogs%': 1,
just a q: do you know when we'll make this a flag?

http://codereview.chromium.org/7780012/diff/3003/views/widget/widget.cc
File views/widget/widget.cc (right):

http://codereview.chromium.org/7780012/diff/3003/views/widget/widget.cc#newco...
views/widget/widget.cc:218: #if defined(TOOLKIT_USES_PURE_VIEWS)
TOOLKIT_USES_PURE_VIEWS and TOOLKIT_USES_GTK will co-exists for a while, so
let's keep the original way.

[Emmanuel Saint-loubert-Bié, 2011-09-10 03:06:31]

Hi Oshima,

I hope my comments explain my goals. If not maybe we can talk in person and
figure out a solution.

Thanks,

-- Emmanuel

http://codereview.chromium.org/7780012/diff/3003/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7780012/diff/3003/build/common.gypi#newcode82
build/common.gypi:82: 'webui_dialogs%': 1,
I assume when rbyers / flackr are further along?

http://codereview.chromium.org/7780012/diff/3003/views/widget/widget.cc
File views/widget/widget.cc (right):

http://codereview.chromium.org/7780012/diff/3003/views/widget/widget.cc#newco...
views/widget/widget.cc:218: #if defined(TOOLKIT_USES_PURE_VIEWS)
The goal of this CL is to have a unique gyp flag (toolkit_use_pure_views) get us
a default build that let us test Pure Views (and soon work in concert with Aura)
for Chrome and for ChromeOS.

PureViews means that we are trying to *not* co-exist (with GTK). And I agree we
are not there. I want to start stubbing out more of GTK (like we do for Wayland
and Aura) under this define so that we can better estimate the size of the GTK
iceberg. Or maybe directly use the Aura stubs (based on the progress of Aura).

We can already coexist today with GTK if we:
 - set toolkit_views=1 (but not toolkit_uses_pure_views)
 - run with --use-pure-views on the command line

Ideally we want to see less of TOUCH_UI and more of specific defines like
USE_VIRTUAL_KEYBOARD, TOOLKIT_USES_PURE_VIEWS...

I certainly can introduce yet another flag, however we have enough of them I
think :-)

[oshima, 2011-09-12 17:53:55]

On 2011/09/10 03:06:31, Emmanuel Saint-loubert wrote:
> Hi Oshima,
> 
> I hope my comments explain my goals. If not maybe we can talk in person and
> figure out a solution.
> 
> Thanks,
> 
> -- Emmanuel
> 
> http://codereview.chromium.org/7780012/diff/3003/build/common.gypi
> File build/common.gypi (right):
> 
> http://codereview.chromium.org/7780012/diff/3003/build/common.gypi#newcode82
> build/common.gypi:82: 'webui_dialogs%': 1,
> I assume when rbyers / flackr are further along?
> 
> http://codereview.chromium.org/7780012/diff/3003/views/widget/widget.cc
> File views/widget/widget.cc (right):
> 
>
http://codereview.chromium.org/7780012/diff/3003/views/widget/widget.cc#newco...
> views/widget/widget.cc:218: #if defined(TOOLKIT_USES_PURE_VIEWS)
> The goal of this CL is to have a unique gyp flag (toolkit_use_pure_views) get
us
> a default build that let us test Pure Views (and soon work in concert with
Aura)
> for Chrome and for ChromeOS.

Switching to pure views should be a command line flag but not gyp/macro. For
aura,
we may not be able to achieve this goal, but pure views should be possible. If
pure views
requires gyp/macro, then there is no use of Views::IsPureViews, isn't it?

> PureViews means that we are trying to *not* co-exist (with GTK). And I agree
we
> are not there. I want to start stubbing out more of GTK (like we do for
Wayland
> and Aura) under this define so that we can better estimate the size of the GTK
> iceberg. Or maybe directly use the Aura stubs (based on the progress of Aura).
> 
> We can already coexist today with GTK if we:
>  - set toolkit_views=1 (but not toolkit_uses_pure_views)
>  - run with --use-pure-views on the command line
> 

current --use-pure-views isn't true pure views. It was my goal that building
with toolkit_uses_pure_views + toolkit_uses_gtk generates gtk/pure views hybrid
that
allow us to switch between gtk and pure views.

If we want to give up --pure-views flag, that'd be another discussion. Let's
discuss 2f2.

> Ideally we want to see less of TOUCH_UI and more of specific defines like
> USE_VIRTUAL_KEYBOARD, TOOLKIT_USES_PURE_VIEWS...
> 
> I certainly can introduce yet another flag, however we have enough of them I
> think :-)

[Emmanuel Saint-loubert-Bié, 2011-09-12 20:09:51]

Hi Oshima,

I renamed the flag to make things (hopefully) clearer. Thanks!

-- Emmanuel

[oshima, 2011-09-12 21:42:09]

LGTM

[commit-bot: I haz the power, 2011-09-13 02:50:25]

Change committed as 100846