Source/WebCore/editing/ReplaceSelectionCommand.cpp - Issue 7780011: Merge 94793 - Crashes in WebCore::ReplaceSelectionCommand::doApply

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/editing/ReplaceSelectionCommand.cpp

Issue 7780011: Merge 94793 - Crashes in WebCore::ReplaceSelectionCommand::doApply (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/874/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebCore/editing/ReplaceSelectionCommand.cpp

===================================================================

--- Source/WebCore/editing/ReplaceSelectionCommand.cpp (revision 94878)

+++ Source/WebCore/editing/ReplaceSelectionCommand.cpp (working copy)

@@ -994,7 +994,7 @@

Node* blockStart = enclosingBlock(insertionPos.deprecatedNode());

if ((isListElement(refNode.get()) || (isLegacyAppleStyleSpan(refNode.get()) && isListElement(refNode->firstChild())))

- && blockStart->renderer()->isListItem())

+ && blockStart && blockStart->renderer()->isListItem())

refNode = insertAsListItems(refNode, blockStart, insertionPos);

else

insertNodeAtAndUpdateNodesInserted(refNode, insertionPos);

« no previous file with comments | « LayoutTests/editing/inserting/insert-without-enclosing-block-expected.txt ('k') | no next file » | no next file with comments »