Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7779053: Make views_aura_desktop depend upon resources so that we don't have to (Closed)

Created:
9 years, 3 months ago by sky
Modified:
9 years, 3 months ago
CC:
chromium-reviews, dhollowa
Visibility:
Public.

Description

Make views_aura_desktop depend upon resources so that we don't have to copy over .pak files and it works on a clean build. Also define NativeComboboxWrapper::CreateWrapper for aura. BUG=none TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99817

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M views/controls/combobox/native_combobox_views.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M views/views.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
9 years, 3 months ago (2011-09-06 17:47:10 UTC) #1
Ben Goodger (Google)
9 years, 3 months ago (2011-09-06 17:48:44 UTC) #2
This is full of fail.

LGTM, but with general disappointment.

-Ben

On Tue, Sep 6, 2011 at 10:47 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Make views_aura_desktop depend upon resources so that we don't have to
> copy over .pak files and it works on a clean build. Also define
> NativeComboboxWrapper::**CreateWrapper for aura.
>
> BUG=none
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/7779053/<http://codereview.chromium.org/7779...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M views/controls/combobox/**native_combobox_views.cc
>  M views/views.gyp
>
>
> Index: views/controls/combobox/**native_combobox_views.cc
> diff --git a/views/controls/combobox/**native_combobox_views.cc
> b/views/controls/combobox/**native_combobox_views.cc
> index 469661585849c437607959454f79c8**ab54815062..**
> 132d63b555404153bdad85b6eb1f52**88f8e149ef 100644
> --- a/views/controls/combobox/**native_combobox_views.cc
> +++ b/views/controls/combobox/**native_combobox_views.cc
> @@ -373,4 +373,15 @@ void NativeComboboxViews::**ShowDropDownMenu() {
>   SetMouseHandler(NULL);
>  }
>
> +/////////////////////////////**//////////////////////////////**
> /////////////////////
> +// NativeComboboxWrapper, public:
> +
> +#if defined(USE_AURA)
> +// static
> +NativeComboboxWrapper* NativeComboboxWrapper::**CreateWrapper(
> +    Combobox* combobox) {
> +  return new NativeComboboxViews(combobox);
> +}
> +#endif
> +
>  }  // namespace views
> Index: views/views.gyp
> diff --git a/views/views.gyp b/views/views.gyp
> index c5f0eda0f0d90f8a96e2a451c094c4**a9917f9ff4..**
> cda9d27bcfe8964ad4886d1de9d70e**f2e7590b7f 100644
> --- a/views/views.gyp
> +++ b/views/views.gyp
> @@ -844,6 +844,7 @@
>           'dependencies': [
>             '../base/base.gyp:base',
>             '../base/base.gyp:base_i18n',
> +            '../chrome/chrome.gyp:packed_**resources',
>             '../skia/skia.gyp:skia',
>             '../third_party/icu/icu.gyp:**icui18n',
>             '../third_party/icu/icu.gyp:**icuuc',
>
>
>

Powered by Google App Engine
This is Rietveld 408576698