Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/v8natives.js

Issue 7779046: Fix map space explosion from changing the arguments and caller properties on native functions. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/accessors.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // Helper function used to install functions on objects. 48 // Helper function used to install functions on objects.
49 function InstallFunctions(object, attributes, functions) { 49 function InstallFunctions(object, attributes, functions) {
50 if (functions.length >= 8) { 50 if (functions.length >= 8) {
51 %OptimizeObjectForAddingMultipleProperties(object, functions.length >> 1); 51 %OptimizeObjectForAddingMultipleProperties(object, functions.length >> 1);
52 } 52 }
53 for (var i = 0; i < functions.length; i += 2) { 53 for (var i = 0; i < functions.length; i += 2) {
54 var key = functions[i]; 54 var key = functions[i];
55 var f = functions[i + 1]; 55 var f = functions[i + 1];
56 %FunctionSetName(f, key); 56 %FunctionSetName(f, key);
57 %FunctionRemovePrototype(f); 57 %FunctionRemovePrototype(f);
58 // We match firefox on this, but not Safari (which does not have the
59 // property at all).
60 %IgnoreAttributesAndSetProperty(f, "caller",
61 null,
62 DONT_ENUM | DONT_DELETE);
63 %IgnoreAttributesAndSetProperty(f, "arguments",
64 null,
65 DONT_ENUM | DONT_DELETE);
66
67 %SetProperty(object, key, f, attributes); 58 %SetProperty(object, key, f, attributes);
68 %SetNativeFlag(f); 59 %SetNativeFlag(f);
69 } 60 }
70 %ToFastProperties(object); 61 %ToFastProperties(object);
71 } 62 }
72 63
73 // Emulates JSC by installing functions on a hidden prototype that 64 // Emulates JSC by installing functions on a hidden prototype that
74 // lies above the current object/prototype. This lets you override 65 // lies above the current object/prototype. This lets you override
75 // functions on String.prototype etc. and then restore the old function 66 // functions on String.prototype etc. and then restore the old function
76 // with delete. See http://code.google.com/p/chromium/issues/detail?id=1717 67 // with delete. See http://code.google.com/p/chromium/issues/detail?id=1717
(...skipping 1475 matching lines...) Expand 10 before | Expand all | Expand 10 after
1552 1543
1553 function SetUpFunction() { 1544 function SetUpFunction() {
1554 %CheckIsBootstrapping(); 1545 %CheckIsBootstrapping();
1555 InstallFunctions($Function.prototype, DONT_ENUM, $Array( 1546 InstallFunctions($Function.prototype, DONT_ENUM, $Array(
1556 "bind", FunctionBind, 1547 "bind", FunctionBind,
1557 "toString", FunctionToString 1548 "toString", FunctionToString
1558 )); 1549 ));
1559 } 1550 }
1560 1551
1561 SetUpFunction(); 1552 SetUpFunction();
OLDNEW
« no previous file with comments | « src/accessors.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698