Issue 7779046: Fix map space explosion from changing the arguments and caller properties on native functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7779046: Fix map space explosion from changing the arguments and caller properties on native functions. (Closed)

Created:
9 years, 3 months ago by Rico

Modified:
9 years, 3 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix map space explosion from changing the arguments and caller properties on native functions. Adding these local properties on all native functions made us do a ConvertDescriptorToField on the callback on each and every native functions, resulting in us creating an extra map for each of these. Committed: http://code.google.com/p/v8/source/detail?r=9152

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -9 lines)			Patch
	M	src/accessors.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	src/v8natives.js	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages