Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 7779041: Let environment variables override make_global_settings. (Closed)

Created:
9 years, 3 months ago by Nico
Modified:
9 years, 3 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Let environment variables override make_global_settings. ?= don't work for CC and CXX, as ?= is equivalent to ifeq ($(origin FOO), undefined) FOO = bar endif and CC's and CXX's origin is "default". See http://www.gnu.org/software/make/manual/make.html (search for "conditional variable assignment" and "The origin function"). Without the ifeq and just ?=, CC and CXX wouldn't be overwritten. With just = instead of ?=, environment variables wouldn't overwrite CC and CXX, which would break the goma make build instructions. Committed: http://code.google.com/p/gyp/source/detail?r=1031

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M pylib/gyp/generator/make.py View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
9 years, 3 months ago (2011-09-06 02:01:05 UTC) #1
Evan Martin
I hate how complex this stuff (make variables, not your patch) is. Are you sure ...
9 years, 3 months ago (2011-09-06 17:27:13 UTC) #2
Nico
New CL up, ptal. (Posterity: there was an email exchange where Evan said he'd like ...
9 years, 3 months ago (2011-09-06 19:06:17 UTC) #3
Evan Martin
LGTM
9 years, 3 months ago (2011-09-06 19:12:57 UTC) #4
Mark Mentovai
9 years, 3 months ago (2011-09-07 01:34:27 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698