Start moving code from BrowserMain to content, so that it can be reused by all embedders of conte...

chrome/browser/browser_main_mac.mm

Index: chrome/browser/browser_main_mac.mm
===================================================================
--- chrome/browser/browser_main_mac.mm	(revision 99756)
+++ chrome/browser/browser_main_mac.mm	(working copy)
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/browser_main_posix.h"
+#include "chrome/browser/browser_main_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
@@ -27,11 +27,15 @@
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/base/resource/resource_bundle.h"
 
+namespace content {
+
 void DidEndMainMessageLoop() {
   AppController* appController = [NSApp delegate];
   [appController didEndMainMessageLoop];
 }
 
+}
+
 void RecordBreakpadStatusUMA(MetricsService* metrics) {
   metrics->RecordBreakpadRegistration(IsCrashReporterEnabled());
   metrics->RecordBreakpadHasDebugger(base::debug::BeingDebugged());
@@ -68,90 +72,80 @@
 
 // BrowserMainPartsMac ---------------------------------------------------------
 
-class BrowserMainPartsMac : public BrowserMainPartsPosix {
- public:
-  explicit BrowserMainPartsMac(const MainFunctionParams& parameters)
-      : BrowserMainPartsPosix(parameters) {}
+BrowserMainPartsMac::BrowserMainPartsMac(const MainFunctionParams& parameters)
+    : BrowserMainPartsPosix(parameters) {
+}
 
- protected:
-  virtual void PreEarlyInitialization() {
-    BrowserMainPartsPosix::PreEarlyInitialization();
+void BrowserMainPartsMac::PreEarlyInitialization() {
+  BrowserMainPartsPosix::PreEarlyInitialization();
 
-    if (base::mac::WasLaunchedAsHiddenLoginItem()) {
-      CommandLine* singleton_command_line = CommandLine::ForCurrentProcess();
-      singleton_command_line->AppendSwitch(switches::kNoStartupWindow);
-    }
+  if (base::mac::WasLaunchedAsHiddenLoginItem()) {
+    CommandLine* singleton_command_line = CommandLine::ForCurrentProcess();
+    singleton_command_line->AppendSwitch(switches::kNoStartupWindow);
   }
+}
 
-  virtual void PreMainMessageLoopStart() {
-    BrowserMainPartsPosix::PreMainMessageLoopStart();
+void BrowserMainPartsMac::PreMainMessageLoopStart() {
+  BrowserMainPartsPosix::PreMainMessageLoopStart();
 
-    // Tell Cooca to finish its initalization, which we want to do manually
-    // instead of calling NSApplicationMain(). The primary reason is that NSAM()
-    // never returns, which would leave all the objects currently on the stack
-    // in scoped_ptrs hanging and never cleaned up. We then load the main nib
-    // directly. The main event loop is run from common code using the
-    // MessageLoop API, which works out ok for us because it's a wrapper around
-    // CFRunLoop.
+  // Tell Cooca to finish its initalization, which we want to do manually

[viettrungluu, 2011/09/06 21:31:42]

s/Cooca/Cocoa
s/initalization/initialization

(even if it's not your fault)

[jam, 2011/09/06 21:50:41]

Done.

+  // instead of calling NSApplicationMain(). The primary reason is that NSAM()
+  // never returns, which would leave all the objects currently on the stack
+  // in scoped_ptrs hanging and never cleaned up. We then load the main nib
+  // directly. The main event loop is run from common code using the
+  // MessageLoop API, which works out ok for us because it's a wrapper around
+  // CFRunLoop.
 
-    // Initialize NSApplication using the custom subclass.
-    [BrowserCrApplication sharedApplication];
+  // Initialize NSApplication using the custom subclass.
+  [BrowserCrApplication sharedApplication];
 
-    // If ui_task is not NULL, the app is actually a browser_test, so startup is
-    // handled outside of BrowserMain (which is what called this).
-    if (!parameters().ui_task) {
-      // The browser process only wants to support the language Cocoa will use,
-      // so force the app locale to be overriden with that value.
-      l10n_util::OverrideLocaleWithCocoaLocale();
+  // If ui_task is not NULL, the app is actually a browser_test, so startup is
+  // handled outside of BrowserMain (which is what called this).
+  if (!parameters().ui_task) {
+    // The browser process only wants to support the language Cocoa will use,
+    // so force the app locale to be overriden with that value.
+    l10n_util::OverrideLocaleWithCocoaLocale();
 
-      // Before we load the nib, we need to start up the resource bundle so we
-      // have the strings avaiable for localization.
-      // TODO(markusheintz): Read preference pref::kApplicationLocale in order
-      // to enforce the application locale.
-      const std::string loaded_locale =
-          ResourceBundle::InitSharedInstance(std::string());
-      CHECK(!loaded_locale.empty()) << "Default locale could not be found";
+    // Before we load the nib, we need to start up the resource bundle so we
+    // have the strings avaiable for localization.
+    // TODO(markusheintz): Read preference pref::kApplicationLocale in order
+    // to enforce the application locale.
+    const std::string loaded_locale =
+        ResourceBundle::InitSharedInstance(std::string());
+    CHECK(!loaded_locale.empty()) << "Default locale could not be found";
 
-      FilePath resources_pack_path;
-      PathService::Get(chrome::FILE_RESOURCES_PACK, &resources_pack_path);
-      ResourceBundle::AddDataPackToSharedInstance(resources_pack_path);
-    }
+    FilePath resources_pack_path;
+    PathService::Get(chrome::FILE_RESOURCES_PACK, &resources_pack_path);
+    ResourceBundle::AddDataPackToSharedInstance(resources_pack_path);
+  }
 
-    // Now load the nib (from the right bundle).
-    scoped_nsobject<NSNib>
-        nib([[NSNib alloc] initWithNibNamed:@"MainMenu"
-                                     bundle:base::mac::MainAppBundle()]);
-    // TODO(viettrungluu): crbug.com/20504 - This currently leaks, so if you
-    // change this, you'll probably need to change the Valgrind suppression.
-    [nib instantiateNibWithOwner:NSApp topLevelObjects:nil];
-    // Make sure the app controller has been created.
-    DCHECK([NSApp delegate]);
+  // Now load the nib (from the right bundle).
+  scoped_nsobject<NSNib>
+      nib([[NSNib alloc] initWithNibNamed:@"MainMenu"
+                                   bundle:base::mac::MainAppBundle()]);
+  // TODO(viettrungluu): crbug.com/20504 - This currently leaks, so if you
+  // change this, you'll probably need to change the Valgrind suppression.
+  [nib instantiateNibWithOwner:NSApp topLevelObjects:nil];
+  // Make sure the app controller has been created.
+  DCHECK([NSApp delegate]);
 
-    // This is a no-op if the KeystoneRegistration framework is not present.
-    // The framework is only distributed with branded Google Chrome builds.
-    [[KeystoneGlue defaultKeystoneGlue] registerWithKeystone];
+  // This is a no-op if the KeystoneRegistration framework is not present.
+  // The framework is only distributed with branded Google Chrome builds.
+  [[KeystoneGlue defaultKeystoneGlue] registerWithKeystone];
 
-    // Prevent Cocoa from turning command-line arguments into
-    // |-application:openFiles:|, since we already handle them directly.
-    [[NSUserDefaults standardUserDefaults]
-        setObject:@"NO" forKey:@"NSTreatUnknownArgumentsAsOpen"];
-  }
+  // Prevent Cocoa from turning command-line arguments into
+  // |-application:openFiles:|, since we already handle them directly.
+  [[NSUserDefaults standardUserDefaults]
+      setObject:@"NO" forKey:@"NSTreatUnknownArgumentsAsOpen"];
+}
 
- private:
-  virtual void InitializeSSL() {
-    // Use NSS for SSL by default.
-    // The default client socket factory uses NSS for SSL by default on Mac.
-    if (parsed_command_line().HasSwitch(switches::kUseSystemSSL)) {
-      net::ClientSocketFactory::UseSystemSSL();
-    } else {
-      // We want to be sure to init NSPR on the main thread.
-      crypto::EnsureNSPRInit();
-    }
+ void BrowserMainPartsMac::InitializeSSL() {
+  // Use NSS for SSL by default.
+  // The default client socket factory uses NSS for SSL by default on Mac.
+  if (parsed_command_line().HasSwitch(switches::kUseSystemSSL)) {
+    net::ClientSocketFactory::UseSystemSSL();
+  } else {
+    // We want to be sure to init NSPR on the main thread.
+    crypto::EnsureNSPRInit();
   }
-};
-
-// static
-BrowserMainParts* BrowserMainParts::CreateBrowserMainParts(
-    const MainFunctionParams& parameters) {
-  return new BrowserMainPartsMac(parameters);
 }