Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2069)

Unified Diff: chrome/browser/browser_main_unittest.cc

Issue 7779040: Start moving code from BrowserMain to content, so that it can be reused by all embedders of conte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix windows unittest Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_main_unittest.cc
===================================================================
--- chrome/browser/browser_main_unittest.cc (revision 99756)
+++ chrome/browser/browser_main_unittest.cc (working copy)
@@ -7,8 +7,11 @@
#include <string>
#include <vector>
#include "base/command_line.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/chrome_content_browser_client.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/testing_pref_service.h"
+#include "content/browser/content_browser_client.h"
#include "content/common/main_function_params.h"
#include "content/common/sandbox_init_wrapper.h"
#include "net/socket/client_socket_pool_base.h"
@@ -32,10 +35,12 @@
scoped_ptr<MainFunctionParams> params(
new MainFunctionParams(command_line_, *sandbox_init_wrapper_, NULL));
- scoped_ptr<BrowserMainParts> bw(BrowserMainParts::CreateBrowserMainParts(
- *params));
+ scoped_ptr<content::BrowserMainParts> bw(
+ content::GetContentClient()->browser()->CreateBrowserMainParts(
+ *params));
- bw->WarmConnectionFieldTrial();
+ ChromeBrowserMainParts* cbw = static_cast<ChromeBrowserMainParts*>(bw.get());
+ cbw->WarmConnectionFieldTrial();
EXPECT_EQ(0, net::GetSocketReusePolicy());
}
@@ -43,12 +48,14 @@
TEST_F(BrowserMainTest, WarmConnectionFieldTrial_Random) {
scoped_ptr<MainFunctionParams> params(
new MainFunctionParams(command_line_, *sandbox_init_wrapper_, NULL));
- scoped_ptr<BrowserMainParts> bw(BrowserMainParts::CreateBrowserMainParts(
- *params));
+ scoped_ptr<content::BrowserMainParts> bw(
+ content::GetContentClient()->browser()->CreateBrowserMainParts(
+ *params));
+ ChromeBrowserMainParts* cbw = static_cast<ChromeBrowserMainParts*>(bw.get());
const int kNumRuns = 1000;
for (int i = 0; i < kNumRuns; i++) {
- bw->WarmConnectionFieldTrial();
+ cbw->WarmConnectionFieldTrial();
int val = net::GetSocketReusePolicy();
EXPECT_LE(val, 2);
EXPECT_GE(val, 0);
@@ -60,9 +67,17 @@
scoped_ptr<MainFunctionParams> params(
new MainFunctionParams(command_line_, *sandbox_init_wrapper_, NULL));
- scoped_ptr<BrowserMainParts> bw(BrowserMainParts::CreateBrowserMainParts(
- *params));
-
- EXPECT_DEBUG_DEATH(bw->WarmConnectionFieldTrial(),
+ // This test ends up launching a new process, and that doesn't initialize the
+ // ContentClient interfaces.
+ scoped_ptr<content::BrowserMainParts> bw;
+ if (content::GetContentClient()) {
+ bw.reset(content::GetContentClient()->browser()->CreateBrowserMainParts(
+ *params));
+ } else {
+ chrome::ChromeContentBrowserClient ccbc;
+ bw.reset(ccbc.CreateBrowserMainParts(*params));
+ }
+ ChromeBrowserMainParts* cbw = static_cast<ChromeBrowserMainParts*>(bw.get());
+ EXPECT_DEBUG_DEATH(cbw->WarmConnectionFieldTrial(),
"Not a valid socket reuse policy group");
}

Powered by Google App Engine
This is Rietveld 408576698