Revert 99617 - Fix nacl_helper startup bug with command line construction.

Revert 99617 - Fix nacl_helper startup bug with command line construction.
Add proper chrome dependencies. Re-enable nacl_helper.





BUG=92964, nativeclient:480, 95168
TEST=nacl_integration tests on bots


Review URL: http://codereview.chromium.org/7833017

TBR=bradchen@google.com
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99619

[Hironori Bono, 2011-09-05 02:31:30]

Greetings,

Unfortunately, I have reverted your r99617 because your change caused a build
break on ARM as listed in the URL (*1). Is your new nacl_helper_bootstrap
supports ARM?

(*1)
<http://chromegw.corp.google.com/i/chromium/builders/Arm/builds/16759/steps/co...>

Regards,

Hironori Bono

[Brad Chen, 2011-09-05 04:02:05]

Bummer, especially since there still aren't any ARM trybots. Do you have any
idea how to test this without a commit?

Brad

On Sun, Sep 4, 2011 at 7:31 PM, <hbono@chromium.org> wrote:

> Greetings,
>
> Unfortunately, I have reverted your r99617 because your change caused a
> build
> break on ARM as listed in the URL (*1). Is your new nacl_helper_bootstrap
> supports ARM?
>
> (*1)
> <http://chromegw.corp.google.**com/i/chromium/builders/Arm/**
>
builds/16759/steps/compile/**logs/stdio<http://chromegw.corp.google.com/i/chromium/builders/Arm/builds/16759/steps/compile/logs/stdio>
> >
>
> Regards,
>
> Hironori Bono
>
>
>
http://codereview.chromium.**org/7779029/<http://codereview.chromium.org/7779...
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[Brad Chen, 2011-09-05 04:02:09]

Bummer, especially since there still aren't any ARM trybots. Do you have any
idea how to test this without a commit?

Brad

On Sun, Sep 4, 2011 at 7:31 PM, <hbono@chromium.org> wrote:

> Greetings,
>
> Unfortunately, I have reverted your r99617 because your change caused a
> build
> break on ARM as listed in the URL (*1). Is your new nacl_helper_bootstrap
> supports ARM?
>
> (*1)
> <http://chromegw.corp.google.**com/i/chromium/builders/Arm/**
>
builds/16759/steps/compile/**logs/stdio<http://chromegw.corp.google.com/i/chromium/builders/Arm/builds/16759/steps/compile/logs/stdio>
> >
>
> Regards,
>
> Hironori Bono
>
>
>
http://codereview.chromium.**org/7779029/<http://codereview.chromium.org/7779...
>

[Brad Chen, 2011-09-05 04:23:52]

Ah wait, looks like there are now some cros arm trybots; we can try those...

Brad

On Sun, Sep 4, 2011 at 9:02 PM, Brad Chen <bradchen@google.com> wrote:

> Bummer, especially since there still aren't any ARM trybots. Do you have
> any idea how to test this without a commit?
>
> Brad
>
> On Sun, Sep 4, 2011 at 7:31 PM, <hbono@chromium.org> wrote:
>
>> Greetings,
>>
>> Unfortunately, I have reverted your r99617 because your change caused a
>> build
>> break on ARM as listed in the URL (*1). Is your new nacl_helper_bootstrap
>> supports ARM?
>>
>> (*1)
>> <http://chromegw.corp.google.**com/i/chromium/builders/Arm/**
>>
builds/16759/steps/compile/**logs/stdio<http://chromegw.corp.google.com/i/chromium/builders/Arm/builds/16759/steps/compile/logs/stdio>
>> >
>>
>> Regards,
>>
>> Hironori Bono
>>
>>
>>
http://codereview.chromium.**org/7779029/<http://codereview.chromium.org/7779...
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[Brad Chen, 2011-09-05 04:23:56]

Ah wait, looks like there are now some cros arm trybots; we can try those...

Brad

On Sun, Sep 4, 2011 at 9:02 PM, Brad Chen <bradchen@google.com> wrote:

> Bummer, especially since there still aren't any ARM trybots. Do you have
> any idea how to test this without a commit?
>
> Brad
>
> On Sun, Sep 4, 2011 at 7:31 PM, <hbono@chromium.org> wrote:
>
>> Greetings,
>>
>> Unfortunately, I have reverted your r99617 because your change caused a
>> build
>> break on ARM as listed in the URL (*1). Is your new nacl_helper_bootstrap
>> supports ARM?
>>
>> (*1)
>> <http://chromegw.corp.google.**com/i/chromium/builders/Arm/**
>>
builds/16759/steps/compile/**logs/stdio<http://chromegw.corp.google.com/i/chromium/builders/Arm/builds/16759/steps/compile/logs/stdio>
>> >
>>
>> Regards,
>>
>> Hironori Bono
>>
>>
>>
http://codereview.chromium.**org/7779029/<http://codereview.chromium.org/7779...
>>
>
>

[Hironori Bono, 2011-09-05 04:27:08]

Greetings,

Yes, cros_arm seems to be an ARM trybot. (I have not tried it yet, though.)

Regards,

Hironori Bono

On 2011/09/05 04:23:56, Brad Chen wrote:
> Ah wait, looks like there are now some cros arm trybots; we can try those...
> 
> Brad