Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 7779029: Revert 99617 - Fix nacl_helper startup bug with command line construction. (Closed)

Created:
9 years, 3 months ago by Hironori Bono
Modified:
9 years, 3 months ago
Reviewers:
Brad Chen
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Revert 99617 - Fix nacl_helper startup bug with command line construction. Add proper chrome dependencies. Re-enable nacl_helper. BUG=92964, nativeclient:480, 95168 TEST=nacl_integration tests on bots Review URL: http://codereview.chromium.org/7833017 TBR=bradchen@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M chrome/chrome_exe.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/nacl/nacl_fork_delegate_linux.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Hironori Bono
9 years, 3 months ago (2011-09-05 02:28:21 UTC) #1
Hironori Bono
Greetings, Unfortunately, I have reverted your r99617 because your change caused a build break on ...
9 years, 3 months ago (2011-09-05 02:31:30 UTC) #2
Brad Chen
Bummer, especially since there still aren't any ARM trybots. Do you have any idea how ...
9 years, 3 months ago (2011-09-05 04:02:05 UTC) #3
Brad Chen
Bummer, especially since there still aren't any ARM trybots. Do you have any idea how ...
9 years, 3 months ago (2011-09-05 04:02:09 UTC) #4
Brad Chen
Ah wait, looks like there are now some cros arm trybots; we can try those... ...
9 years, 3 months ago (2011-09-05 04:23:52 UTC) #5
Brad Chen
Ah wait, looks like there are now some cros arm trybots; we can try those... ...
9 years, 3 months ago (2011-09-05 04:23:56 UTC) #6
Hironori Bono
9 years, 3 months ago (2011-09-05 04:27:08 UTC) #7
Greetings,

Yes, cros_arm seems to be an ARM trybot. (I have not tried it yet, though.)

Regards,

Hironori Bono

On 2011/09/05 04:23:56, Brad Chen wrote:
> Ah wait, looks like there are now some cros arm trybots; we can try those...
> 
> Brad

Powered by Google App Engine
This is Rietveld 408576698