Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 7779019: Removed sample.pak binary from checkout. (Closed)

Created:
9 years, 3 months ago by marcvs
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., Nebojša Ćirić
Visibility:
Public.

Description

Removed sample.pak binary from checkout. Replaced by hexa literal in the two ui_unittests that need it. This will make any later changes easier to perform, and it also eliminates the problem of having binary files which are ignored by patches in the repo. BUG=none TEST=ui_unittest:{DataPackTest.*, ResourceBundle.*} Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99842

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -7 lines) Patch
A ui/base/resource/data_pack_literal.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M ui/base/resource/data_pack_unittest.cc View 1 1 chunk +11 lines, -4 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 1 2 chunks +13 lines, -4 lines 0 comments Download
D ui/base/test/data/data_pack_unittest/sample.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
marcvs
9 years, 3 months ago (2011-09-02 23:04:00 UTC) #1
tony
http://codereview.chromium.org/7779019/diff/1/ui/base/resource/data_pack_unittest.cc File ui/base/resource/data_pack_unittest.cc (right): http://codereview.chromium.org/7779019/diff/1/ui/base/resource/data_pack_unittest.cc#newcode24 ui/base/resource/data_pack_unittest.cc:24: FILE* file = file_util::OpenFile(data_path, "wb"); Can we just use ...
9 years, 3 months ago (2011-09-02 23:10:51 UTC) #2
marcvs
http://codereview.chromium.org/7779019/diff/1/ui/base/resource/data_pack_unittest.cc File ui/base/resource/data_pack_unittest.cc (right): http://codereview.chromium.org/7779019/diff/1/ui/base/resource/data_pack_unittest.cc#newcode24 ui/base/resource/data_pack_unittest.cc:24: FILE* file = file_util::OpenFile(data_path, "wb"); On 2011/09/02 23:10:51, tony ...
9 years, 3 months ago (2011-09-02 23:27:26 UTC) #3
tony
LGTM!
9 years, 3 months ago (2011-09-02 23:30:32 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-09-06 22:31:42 UTC) #5
Change committed as 99842

Powered by Google App Engine
This is Rietveld 408576698