Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 7779018: Get rid of unnecessary chrome_main_ files now that most of the code has been removed from them. I... (Closed)

Created:
9 years, 3 months ago by jam
Modified:
9 years, 3 months ago
Reviewers:
tony
CC:
chromium-reviews
Visibility:
Public.

Description

Get rid of unnecessary chrome_main_ files now that most of the code has been removed from them. I just kept the Mac one since we need a file that can include objective c files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99836

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -153 lines) Patch
D chrome/app/chrome_main.h View 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/app/chrome_main.cc View 1 2 6 chunks +55 lines, -4 lines 0 comments Download
A + chrome/app/chrome_main_mac.h View 1 chunk +3 lines, -17 lines 0 comments Download
M chrome/app/chrome_main_mac.mm View 1 2 3 chunks +1 line, -5 lines 0 comments Download
D chrome/app/chrome_main_posix.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/app/chrome_main_win.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 chunks +1 line, -3 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
9 years, 3 months ago (2011-09-02 23:17:04 UTC) #1
tony
LGTM http://codereview.chromium.org/7779018/diff/7002/chrome/chrome_dll.gypi File chrome/chrome_dll.gypi (left): http://codereview.chromium.org/7779018/diff/7002/chrome/chrome_dll.gypi#oldcode222 chrome/chrome_dll.gypi:222: 'app/chrome_main_posix.cc', Nit: add chrome_main_mac.h
9 years, 3 months ago (2011-09-02 23:59:15 UTC) #2
jam
9 years, 3 months ago (2011-09-03 00:08:46 UTC) #3
http://codereview.chromium.org/7779018/diff/7002/chrome/chrome_dll.gypi
File chrome/chrome_dll.gypi (left):

http://codereview.chromium.org/7779018/diff/7002/chrome/chrome_dll.gypi#oldco...
chrome/chrome_dll.gypi:222: 'app/chrome_main_posix.cc',
On 2011/09/02 23:59:15, tony wrote:
> Nit: add chrome_main_mac.h

Done.

Powered by Google App Engine
This is Rietveld 408576698