Issue 7779012: renderer: Fix referencing v8::Array and v8::Object using raw pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7779012: renderer: Fix referencing v8::Array and v8::Object using raw pointer. (Closed)

Created:
9 years, 3 months ago by tfarina

Modified:
9 years, 3 months ago

Reviewers:
tonyg, mnaganov (inactive)

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

renderer: Fix referencing v8::Array and v8::Object using raw pointer. We should never use raw pointers of v8 objects in client code. We should always use v8::Handle and it subclasses, v8::Local and v8::Persistent, whenever referencing them. Any allocation from v8 heap can make raw pointers invalid. BUG=None TEST=None R=mnaganov@chromium.org TBR=tonyg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98865

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/renderer/searchbox_extension.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

9 years, 3 months ago (2011-08-30 10:31:10 UTC) #2

On 2011/08/29 15:02:40, tfarina wrote:
> Mikhail, please review!
> 
> Tony, fyi!

LGTM

Expand Messages | Collapse Messages