content/common/view_messages.h - Issue 7779010: Implements frame sniffer to watch iframe loading state.

Side by Side Diff: content/common/view_messages.h

Issue 7779010: Implements frame sniffer to watch iframe loading state. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: clang fix Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/chromeos/login/screen_offline_message.html ('K') | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc ('k') | content/content_renderer.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for page rendering.	5 // IPC messages for page rendering.

6 // Multiply-included message file, hence no include guard.	6 // Multiply-included message file, hence no include guard.

7	7

8 #include "base/process.h"	8 #include "base/process.h"

9 #include "base/shared_memory.h"	9 #include "base/shared_memory.h"

10 #include "content/common/common_param_traits.h"	10 #include "content/common/common_param_traits.h"

(...skipping 2077 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2088 int32 /* complete status */)	2088 int32 /* complete status */)

2089	2089

2090 // Request updated information about the client firewall traversal policy.	2090 // Request updated information about the client firewall traversal policy.

2091 // Will result in a ViewMsg_UpdateRemoteAccessClientFirewallTraversal message	2091 // Will result in a ViewMsg_UpdateRemoteAccessClientFirewallTraversal message

2092 // being sent back.	2092 // being sent back.

2093 IPC_MESSAGE_ROUTED0(ViewHostMsg_RequestRemoteAccessClientFirewallTraversal)	2093 IPC_MESSAGE_ROUTED0(ViewHostMsg_RequestRemoteAccessClientFirewallTraversal)

2094	2094

2095 // Notifies the browser of an event occurring in the media pipeline.	2095 // Notifies the browser of an event occurring in the media pipeline.

2096 IPC_MESSAGE_CONTROL1(ViewHostMsg_MediaLogEvent,	2096 IPC_MESSAGE_CONTROL1(ViewHostMsg_MediaLogEvent,

2097 media::MediaLogEvent /* event */)	2097 media::MediaLogEvent /* event */)

	2098

	2099 // This message indicates the error appeared in the frame.

	2100 IPC_MESSAGE_ROUTED1(ViewHostMsg_FrameLoadingError,

	2101 int /* error */)

	2102

	2103 // This message asks frame sniffer start.

	2104 IPC_MESSAGE_ROUTED1(ViewMsg_StartFrameSniffer,
	jam 2011/08/31 16:36:41 the messages are separated by ViewMsg first, then the messages are separated by ViewMsg first, then ViewHostMsg altimofeev 2011/09/02 15:26:36 Done. Show quoted text On 2011/08/31 16:36:41, John Abd-El-Malek wrote: > the messages are separated by ViewMsg first, then ViewHostMsg Done. jam 2011/09/02 16:52:59 sorry maybe I should have been more verbose :) Wha Show quoted text On 2011/09/02 15:26:36, altimofeev wrote: > On 2011/08/31 16:36:41, John Abd-El-Malek wrote: > > the messages are separated by ViewMsg first, then ViewHostMsg > > Done. sorry maybe I should have been more verbose :) What I mean is you'll notice that all the ViewMsg messages come first, then all the ViewHostMsg. so if you add two messages that are different, they won't be beside each other. i.e. ViewMsg_StartFrameSniffer would go in line 1250. but, since this is a message that's sent and received in chrome, it doesn't belong in content. so it should be moved to chrome\common\render_messages.h and be called ChromeViewHostMsg and ChromeViewMsg like the other messages there (that's what I meant when I said that content shouldn't be changed at all)
	2105 string16 /* frame-name */)

OLD	NEW