Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 7779007: MIPS: Fixed a RecordWrite call in the FullCodeGenerator. (Closed)
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1515 matching lines...) Expand 10 before | Expand all | Expand 10 after
1526 VisitForAccumulatorValue(subexpr); 1526 VisitForAccumulatorValue(subexpr);
1527 1527
1528 // Store the subexpression value in the array's elements. 1528 // Store the subexpression value in the array's elements.
1529 __ lw(a1, MemOperand(sp)); // Copy of array literal. 1529 __ lw(a1, MemOperand(sp)); // Copy of array literal.
1530 __ lw(a1, FieldMemOperand(a1, JSObject::kElementsOffset)); 1530 __ lw(a1, FieldMemOperand(a1, JSObject::kElementsOffset));
1531 int offset = FixedArray::kHeaderSize + (i * kPointerSize); 1531 int offset = FixedArray::kHeaderSize + (i * kPointerSize);
1532 __ sw(result_register(), FieldMemOperand(a1, offset)); 1532 __ sw(result_register(), FieldMemOperand(a1, offset));
1533 1533
1534 // Update the write barrier for the array store with v0 as the scratch 1534 // Update the write barrier for the array store with v0 as the scratch
1535 // register. 1535 // register.
1536 __ li(a2, Operand(offset)); 1536 __ RecordWrite(a1, Operand(offset), a2, result_register());
1537 // TODO(PJ): double check this RecordWrite call.
1538 __ RecordWrite(a1, a2, result_register());
1539 1537
1540 PrepareForBailoutForId(expr->GetIdForElement(i), NO_REGISTERS); 1538 PrepareForBailoutForId(expr->GetIdForElement(i), NO_REGISTERS);
1541 } 1539 }
1542 1540
1543 if (result_saved) { 1541 if (result_saved) {
1544 context()->PlugTOS(); 1542 context()->PlugTOS();
1545 } else { 1543 } else {
1546 context()->Plug(v0); 1544 context()->Plug(v0);
1547 } 1545 }
1548 } 1546 }
(...skipping 2736 matching lines...) Expand 10 before | Expand all | Expand 10 after
4285 __ Addu(at, a1, Operand(masm_->CodeObject())); 4283 __ Addu(at, a1, Operand(masm_->CodeObject()));
4286 __ Jump(at); 4284 __ Jump(at);
4287 } 4285 }
4288 4286
4289 4287
4290 #undef __ 4288 #undef __
4291 4289
4292 } } // namespace v8::internal 4290 } } // namespace v8::internal
4293 4291
4294 #endif // V8_TARGET_ARCH_MIPS 4292 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698