Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: ppapi/c/dev/ppb_video_decoder_dev.h

Issue 7779001: Replace the use of an int32* with a proper struct for decoder configuration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replaced struct with explicit profile parameter. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/c/dev/ppb_video_decoder_dev.h
diff --git a/ppapi/c/dev/ppb_video_decoder_dev.h b/ppapi/c/dev/ppb_video_decoder_dev.h
index 5a3417e2e176a374770e4e80d677a20098092532..aab226e4c51f9877006ae4af53eebed481f25c15 100644
--- a/ppapi/c/dev/ppb_video_decoder_dev.h
+++ b/ppapi/c/dev/ppb_video_decoder_dev.h
@@ -9,8 +9,8 @@
#include "ppapi/c/pp_completion_callback.h"
#include "ppapi/c/pp_var.h"
-#define PPB_VIDEODECODER_DEV_INTERFACE_0_15 "PPB_VideoDecoder(Dev);0.15"
-#define PPB_VIDEODECODER_DEV_INTERFACE PPB_VIDEODECODER_DEV_INTERFACE_0_15
+#define PPB_VIDEODECODER_DEV_INTERFACE_0_16 "PPB_VideoDecoder(Dev);0.16"
+#define PPB_VIDEODECODER_DEV_INTERFACE PPB_VIDEODECODER_DEV_INTERFACE_0_16
// Video decoder interface.
//
@@ -35,14 +35,12 @@ struct PPB_VideoDecoder_Dev {
// Parameters:
// |instance| pointer to the plugin instance.
// |context_3d| a PPB_Context3D_Dev resource in which decoding will happen.
- // |decoder_config| the configuration to use to initialize the decoder.
+ // |profile| the video stream's format profile.
//
// The created decoder is returned as PP_Resource. 0 means failure.
- // TODO(fischman/vrk): Get rid of silly PP_VideoConfigElement* vector in favor
- // of config struct.
PP_Resource (*Create)(PP_Instance instance,
PP_Resource context,
- const PP_VideoConfigElement* decoder_config);
+ enum PP_VideoDecoder_Profile profile);
// Tests whether |resource| is a video decoder created through Create
// function of this interface.

Powered by Google App Engine
This is Rietveld 408576698