Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: content/common/gpu/media/omx_video_decode_accelerator_unittest.cc

Issue 7779001: Replace the use of an int32* with a proper struct for decoder configuration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replaced struct with explicit profile parameter. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/omx_video_decode_accelerator_unittest.cc
diff --git a/content/common/gpu/media/omx_video_decode_accelerator_unittest.cc b/content/common/gpu/media/omx_video_decode_accelerator_unittest.cc
index 49498e52489ad5d0de40c0ea2953040080175ac3..a2d4eb74391d14394587ade2c6b9228d89a7489f 100644
--- a/content/common/gpu/media/omx_video_decode_accelerator_unittest.cc
+++ b/content/common/gpu/media/omx_video_decode_accelerator_unittest.cc
@@ -575,18 +575,11 @@ void EglRenderingVDAClient::CreateDecoder() {
return;
// Configure the decoder.
- int32 config_array[] = {
- media::VIDEOATTRIBUTEKEY_BITSTREAMFORMAT_FOURCC,
- media::VIDEOCODECFOURCC_H264,
- media::VIDEOATTRIBUTEKEY_VIDEOCOLORFORMAT, media::VIDEOCOLORFORMAT_RGBA,
- };
- std::vector<int32> config(
- config_array, config_array + arraysize(config_array));
- if (profile_ != -1) {
- config.push_back(media::VIDEOATTRIBUTEKEY_BITSTREAMFORMAT_H264_PROFILE);
- config.push_back(profile_);
- }
- CHECK(decoder_->Initialize(config));
+ media::VideoDecodeAccelerator::Profile profile =
+ media::VideoDecodeAccelerator::H264PROFILE_BASELINE;
+ if (profile_ != -1)
+ profile = static_cast<media::VideoDecodeAccelerator::Profile>(profile_);
+ CHECK(decoder_->Initialize(profile));
}
void EglRenderingVDAClient::ProvidePictureBuffers(

Powered by Google App Engine
This is Rietveld 408576698