Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: content/common/gpu/media/omx_video_decode_accelerator.h

Issue 7779001: Replace the use of an int32* with a proper struct for decoder configuration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replaced struct with explicit profile parameter. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/omx_video_decode_accelerator.h
diff --git a/content/common/gpu/media/omx_video_decode_accelerator.h b/content/common/gpu/media/omx_video_decode_accelerator.h
index b74406854aeb7a107647772a6ebb612ad4a17c6d..d76cc5eaf31872646578917d1829ac40c78670b0 100644
--- a/content/common/gpu/media/omx_video_decode_accelerator.h
+++ b/content/common/gpu/media/omx_video_decode_accelerator.h
@@ -42,7 +42,7 @@ class OmxVideoDecodeAccelerator : public media::VideoDecodeAccelerator {
OmxVideoDecodeAccelerator(media::VideoDecodeAccelerator::Client* client);
// media::VideoDecodeAccelerator implementation.
- bool Initialize(const std::vector<int32>& config) OVERRIDE;
+ bool Initialize(Profile profile) OVERRIDE;
void Decode(const media::BitstreamBuffer& bitstream_buffer) OVERRIDE;
virtual void AssignPictureBuffers(
const std::vector<media::PictureBuffer>& buffers) OVERRIDE;
@@ -82,9 +82,6 @@ class OmxVideoDecodeAccelerator : public media::VideoDecodeAccelerator {
};
typedef std::map<int32, OutputPicture> OutputPictureById;
- // Verify that |config| is compatible with this class and hardware.
- bool VerifyConfigs(const std::vector<int32>& configs);
-
MessageLoop* message_loop_;
OMX_HANDLETYPE component_handle_;
@@ -185,7 +182,7 @@ class OmxVideoDecodeAccelerator : public media::VideoDecodeAccelerator {
Client* client_;
// These two members are only used during Initialization.
- // OMX_VIDEO_AVCProfile requested during Initialization.
+ // OMX_AVCProfile requested during Initialization.
uint32 profile_;
bool component_name_is_nvidia_h264ext_;

Powered by Google App Engine
This is Rietveld 408576698