content/common/gpu/media/omx_video_decode_accelerator_unittest.cc - Issue 7779001: Replace the use of an int32* with a proper struct for decoder configuration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/omx_video_decode_accelerator_unittest.cc

Issue 7779001: Replace the use of an int32* with a proper struct for decoder configuration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/omx_video_decode_accelerator.cc ('k') | content/renderer/gpu/command_buffer_proxy.h » ('j') | ppapi/cpp/dev/video_decoder_dev.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/omx_video_decode_accelerator_unittest.cc

diff --git a/content/common/gpu/media/omx_video_decode_accelerator_unittest.cc b/content/common/gpu/media/omx_video_decode_accelerator_unittest.cc

index 49498e52489ad5d0de40c0ea2953040080175ac3..ec6021e308a833f46f0ec47d08012f61169bfdff 100644

--- a/content/common/gpu/media/omx_video_decode_accelerator_unittest.cc

+++ b/content/common/gpu/media/omx_video_decode_accelerator_unittest.cc

@@ -575,17 +575,11 @@ void EglRenderingVDAClient::CreateDecoder() {

return;

// Configure the decoder.

- int32 config_array[] = {

- media::VIDEOATTRIBUTEKEY_BITSTREAMFORMAT_FOURCC,

- media::VIDEOCODECFOURCC_H264,

- media::VIDEOATTRIBUTEKEY_VIDEOCOLORFORMAT, media::VIDEOCOLORFORMAT_RGBA,

- };

- std::vector<int32> config(

- config_array, config_array + arraysize(config_array));

- if (profile_ != -1) {

- config.push_back(media::VIDEOATTRIBUTEKEY_BITSTREAMFORMAT_H264_PROFILE);

- config.push_back(profile_);

- }

+ typedef media::VideoDecodeAccelerator::Config Config;

+ Config config;

+ config.format = media::VideoDecodeAccelerator::Config::H264;

+ if (profile_ != -1)

+ config.h264_profile = static_cast<Config::H264Profile>(profile_);

CHECK(decoder_->Initialize(config));

}