Replace the use of an int32* with a proper struct for decoder configuration.

Replace the use of an int32* with an explicit profile for decoder configuration.

Replaces the error-prone, overly-general, error-containing, and brittle
manually-terminated array-of-ints holding name/value pairs (except for names
that don't take values) with a simple profile parameter (specifying only information we
actually use today).

BUG=none
TEST=trybots, ovdatest, gles2

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99111

[brettw, 2011-08-31 15:45:38]

http://codereview.chromium.org/7779001/diff/4001/ppapi/cpp/dev/video_decoder_...
File ppapi/cpp/dev/video_decoder_dev.h (right):

http://codereview.chromium.org/7779001/diff/4001/ppapi/cpp/dev/video_decoder_...
ppapi/cpp/dev/video_decoder_dev.h:28: VideoDecoder_Dev(const Instance& instance,
While you're here, can you convert the Instance& to Instance* in these two
constructors? We've been using pointers for instance parameters. Since calling
code is usually in the instance object, it's nicer to pass "this" instead of
"*this".

[Ami GONE FROM CHROMIUM, 2011-08-31 18:28:34]

Brett: this is ready for real review now.  Wanna do it?

http://codereview.chromium.org/7779001/diff/4001/ppapi/cpp/dev/video_decoder_...
File ppapi/cpp/dev/video_decoder_dev.h (right):

http://codereview.chromium.org/7779001/diff/4001/ppapi/cpp/dev/video_decoder_...
ppapi/cpp/dev/video_decoder_dev.h:28: VideoDecoder_Dev(const Instance& instance,
On 2011/08/31 15:45:38, brettw wrote:
> While you're here, can you convert the Instance& to Instance* in these two
> constructors? We've been using pointers for instance parameters. Since calling
> code is usually in the instance object, it's nicer to pass "this" instead of
> "*this".

Done.

[brettw, 2011-08-31 19:53:37]

http://codereview.chromium.org/7779001/diff/8002/content/common/gpu/DEPS
File content/common/gpu/DEPS (right):

http://codereview.chromium.org/7779001/diff/8002/content/common/gpu/DEPS#newc...
content/common/gpu/DEPS:6: "+media/video/video_decode_accelerator.h",
Maybe it's better to move the enum you need to media/base (which is already used
by common). What do you think?

[Ami GONE FROM CHROMIUM, 2011-08-31 19:59:39]

http://codereview.chromium.org/7779001/diff/8002/content/common/gpu/DEPS
File content/common/gpu/DEPS (right):

http://codereview.chromium.org/7779001/diff/8002/content/common/gpu/DEPS#newc...
content/common/gpu/DEPS:6: "+media/video/video_decode_accelerator.h",
On 2011/08/31 19:53:37, brettw wrote:
> Maybe it's better to move the enum you need to media/base (which is already
used
> by common). What do you think?

I think a better move would be to narrow content/common/DEPS to specify the
exact file depended-upon, instead of the dir+comment we have now.  Instead of:
  "+media/base", # For media_log_event.h.
use:
  "+media/base/media_log_event.h",

I can send a CL for that.

[Ami GONE FROM CHROMIUM, 2011-09-01 02:58:53]

On 2011/08/31 19:59:39, Ami Fischman wrote:
> http://codereview.chromium.org/7779001/diff/8002/content/common/gpu/DEPS
> File content/common/gpu/DEPS (right):
> 
>
http://codereview.chromium.org/7779001/diff/8002/content/common/gpu/DEPS#newc...
> content/common/gpu/DEPS:6: "+media/video/video_decode_accelerator.h",
> On 2011/08/31 19:53:37, brettw wrote:
> > Maybe it's better to move the enum you need to media/base (which is already
> used
> > by common). What do you think?
> 
> I think a better move would be to narrow content/common/DEPS to specify the
> exact file depended-upon, instead of the dir+comment we have now.  Instead of:
>   "+media/base", # For media_log_event.h.
> use:
>   "+media/base/media_log_event.h",
> 
> I can send a CL for that.

FTR that went out as http://codereview.chromium.org/7821002/

[brettw, 2011-09-01 03:05:31]

LGTM

[commit-bot: I haz the power, 2011-09-01 03:12:52]

Can't apply patch for file content/common/gpu/DEPS.
While running patch -p1 --forward --force;
patching file content/common/gpu/DEPS
Hunk #1 FAILED at 3.
1 out of 1 hunk FAILED -- saving rejects to file content/common/gpu/DEPS.rej