[cros] Support global carrier config.

[cros] Support global carrier config.
Local carrier config override will be added in next CL.

BUG=chrome-os-partner:5764
TEST=Manual.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99643

[Dmitry Polukhin, 2011-09-05 06:33:11]

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/cust...
File chrome/browser/chromeos/customization_document.h (right):

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/cust...
chrome/browser/chromeos/customization_document.h:132:
FRIEND_TEST(ServicesCustomizationDocumentTest, Basic);
Please replace with FRIEND_TEST_ALL_PREFIXES.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
File chrome/browser/chromeos/mobile_config.cc (right):

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
chrome/browser/chromeos/mobile_config.cc:123: CarrierDeal* deal = new
CarrierDeal(deal_dict);
It looks like, here there is memory leak. |deal| may not be inserted in the map
and pointers in the map are not deleted in d-tor.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
chrome/browser/chromeos/mobile_config.cc:258: Carrier* carrier = new
Carrier(carrier_dict, initial_locale_);
There is similar memory leak here.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
File chrome/browser/chromeos/mobile_config.h (right):

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
chrome/browser/chromeos/mobile_config.h:29: // First global configuration is
loaded then local one.
It looks like local file is not implemented yet, right? It looks like we need
local config to disable carrier promos on Mario.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
chrome/browser/chromeos/mobile_config.h:32: class MobileConfig {
What about inheriting from CustomizationDocument, it basically provides the same
base interface and it also eliminate some code duplication.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
chrome/browser/chromeos/mobile_config.h:111: FRIEND_TEST(MobileConfigTest,
Basic);
Please replace with FRIEND_TEST_ALL_PREFIXES.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/stat...
File chrome/browser/chromeos/status/network_menu_button.cc (right):

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/stat...
chrome/browser/chromeos/status/network_menu_button.cc:359: const
MobileConfig::Carrier* carrier = GetCarrier(cros);
Carrier can be NULL you need to check it here.

[Nikita (slow), 2011-09-05 10:13:44]

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/cust...
File chrome/browser/chromeos/customization_document.h (right):

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/cust...
chrome/browser/chromeos/customization_document.h:132:
FRIEND_TEST(ServicesCustomizationDocumentTest, Basic);
On 2011/09/05 06:33:11, Dmitry Polukhin wrote:
> Please replace with FRIEND_TEST_ALL_PREFIXES.

Done.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
File chrome/browser/chromeos/mobile_config.cc (right):

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
chrome/browser/chromeos/mobile_config.cc:123: CarrierDeal* deal = new
CarrierDeal(deal_dict);
On 2011/09/05 06:33:11, Dmitry Polukhin wrote:
> It looks like, here there is memory leak. |deal| may not be inserted in the
map
> and pointers in the map are not deleted in d-tor.

Done.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
chrome/browser/chromeos/mobile_config.cc:258: Carrier* carrier = new
Carrier(carrier_dict, initial_locale_);
On 2011/09/05 06:33:11, Dmitry Polukhin wrote:
> There is similar memory leak here.

Done.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
File chrome/browser/chromeos/mobile_config.h (right):

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
chrome/browser/chromeos/mobile_config.h:29: // First global configuration is
loaded then local one.
On 2011/09/05 06:33:11, Dmitry Polukhin wrote:
> It looks like local file is not implemented yet, right? It looks like we need
> local config to disable carrier promos on Mario.

Yes, I'll do that in next CL.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
chrome/browser/chromeos/mobile_config.h:32: class MobileConfig {
On 2011/09/05 06:33:11, Dmitry Polukhin wrote:
> What about inheriting from CustomizationDocument, it basically provides the
same
> base interface and it also eliminate some code duplication.

Done.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/mobi...
chrome/browser/chromeos/mobile_config.h:111: FRIEND_TEST(MobileConfigTest,
Basic);
On 2011/09/05 06:33:11, Dmitry Polukhin wrote:
> Please replace with FRIEND_TEST_ALL_PREFIXES.

Done.

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/stat...
File chrome/browser/chromeos/status/network_menu_button.cc (right):

http://codereview.chromium.org/7778043/diff/5001/chrome/browser/chromeos/stat...
chrome/browser/chromeos/status/network_menu_button.cc:359: const
MobileConfig::Carrier* carrier = GetCarrier(cros);
On 2011/09/05 06:33:11, Dmitry Polukhin wrote:
> Carrier can be NULL you need to check it here.

Done.

[Dmitry Polukhin, 2011-09-05 10:27:27]

LGTM