Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 7778035: Revert 98885 - Third attempt at the following. Unreviewed, this was originally reviewed in http:... (Closed)

Created:
9 years, 3 months ago by Ryan Sleevi
Modified:
9 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 98885 - Third attempt at the following. Unreviewed, this was originally reviewed in http://codereview.chromium.org/7550002 . Clean up SSL false start blacklist code. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7804001 TBR=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -284 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M base/third_party/dynamic_annotations/dynamic_annotations.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/linux/system.gyp View 12 chunks +16 lines, -56 lines 0 comments Download
M build/util/build_util.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/ssl_config_service.cc View 1 chunk +1 line, -1 line 0 comments Download
net/base/ssl_false_start_blacklist.h View 2 chunks +51 lines, -31 lines 0 comments Download
MM net/base/ssl_false_start_blacklist.cc View 2 chunks +14 lines, -11 lines 0 comments Download
M net/base/ssl_false_start_blacklist_process.cc View 2 chunks +214 lines, -157 lines 0 comments Download
MM net/base/ssl_false_start_blacklist_unittest.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M net/net.gyp View 5 chunks +4 lines, -10 lines 0 comments Download
M third_party/libevent/libevent.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/modp_b64/modp_b64.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ryan Sleevi
9 years, 3 months ago (2011-08-31 02:35:11 UTC) #1
Ryan Sleevi
Sadly, my "quick fix" tickled out a new problem on the v8 gyp side. Filed ...
9 years, 3 months ago (2011-08-31 02:57:00 UTC) #2
Peter Kasting
9 years, 3 months ago (2011-08-31 17:10:03 UTC) #3
LGTM.  Thanks for the investigation on this.

Powered by Google App Engine
This is Rietveld 408576698