Add trace code to track all posted tasks in message_loop.

base/tracked_objects.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/tracked_objects.h"
 
 #include <math.h>
 
 #include "base/format_macros.h"
 #include "base/message_loop.h"
@@ skipping 653 matching lines @@
 }
 
 void Aggregation::Write(std::string* output) const {
   if (locations_.size() == 1) {
     locations_.begin()->first.Write(true, true, output);
   } else {
     base::StringAppendF(output, "%" PRIuS " Locations. ", locations_.size());
     if (birth_files_.size() > 1) {
       base::StringAppendF(output, "%" PRIuS " Files. ", birth_files_.size());
     } else {
-      base::StringAppendF(output, "All born in %s. ",
-                          birth_files_.begin()->first.c_str());
+      output->append("All born in ");
+      birth_files_.begin()->first.AppendToString(output);
+      output->append(". ");
     }
   }
 
   if (birth_threads_.size() > 1) {
     base::StringAppendF(output, "%" PRIuS " BirthingThreads. ",
                         birth_threads_.size());
   } else {
     base::StringAppendF(output, "All born on %s. ",
                         birth_threads_.begin()->first->ThreadName().c_str());
   }
@@ skipping 62 matching lines @@
         if (!left.death_thread())
           return true;
         if (!right.death_thread())
           return false;
         return left.DeathThreadName() <
              right.DeathThreadName();
       }
       break;
 
     case BIRTH_FILE:
-      if (left.location().file_name() != right.location().file_name()) {
-        int comp = strcmp(left.location().file_name(),
-                          right.location().file_name());
-        if (comp)
-          return 0 > comp;
+      {
+        base::StringPiece left_file = left.location().file_name();
+        base::StringPiece right_file = right.location().file_name();
+        if (left_file != right_file)
+          return left_file < right_file;
       }
       break;
 
     case BIRTH_FUNCTION:
-      if (left.location().function_name() != right.location().function_name()) {
-        int comp = strcmp(left.location().function_name(),
-                          right.location().function_name());
-        if (comp)
-          return 0 > comp;
+      {
+        base::StringPiece left_function = left.location().function_name();
+        base::StringPiece right_function = right.location().function_name();
+        if (left_function != right_function)
+          return left_function < right_function;
       }
       break;
 
     case BIRTH_LINE:
-      if (left.location().line_number() != right.location().line_number())
-        return left.location().line_number() <
-            right.location().line_number();
+      {
+        int left_line = left.location().line_number();
+        int right_line = right.location().line_number();
+        if (left_line != right_line)
+          return left_line < right_line;
+      }
       break;
 
     case COUNT:
       if (left.count() != right.count())
         return left.count() > right.count();  // Sort large at front of vector.
       break;
 
     case AVERAGE_DURATION:
       if (!left.count() || !right.count())
         break;
@@ skipping 23 matching lines @@
         return false;
       break;
 
     case DEATH_THREAD:
       if (left.death_thread() != right.death_thread() &&
           left.DeathThreadName() != right.DeathThreadName())
         return false;
       break;
 
     case BIRTH_FILE:
-      if (left.location().file_name() != right.location().file_name()) {
-        int comp = strcmp(left.location().file_name(),
-                          right.location().file_name());
-        if (comp)
-          return false;
-      }
+      if (left.location().file_name() != right.location().file_name())
+        return false;
       break;
 
     case BIRTH_FUNCTION:
-      if (left.location().function_name() != right.location().function_name()) {
-        int comp = strcmp(left.location().function_name(),
-                          right.location().function_name());
-        if (comp)
-          return false;
-      }
+      if (left.location().function_name() != right.location().function_name())
+        return false;
       break;
 
     case COUNT:
       if (left.count() != right.count())
         return false;
       break;
 
     case AVERAGE_DURATION:
       if (left.life_duration() != right.life_duration())
         return false;
@@ skipping 15 matching lines @@
             std::string::npos)
           return false;
         break;
 
       case DEATH_THREAD:
         if (sample.DeathThreadName().find(required_) == std::string::npos)
           return false;
         break;
 
       case BIRTH_FILE:
-        if (!strstr(sample.location().file_name(), required_.c_str()))
+        if (sample.location().file_name().find(required_.c_str()) ==

[jar (doing other things), 2011/09/01 18:17:51]

Since you have transition to passing SringPieces objects, you no longer need the
.c_str() in the argument (to find).

[jbates, 2011/09/01 23:01:52]

Done.

+            base::StringPiece::npos)
           return false;
         break;
 
       case BIRTH_FUNCTION:
-        if (!strstr(sample.location().function_name(), required_.c_str()))
+        if (sample.location().function_name().find(required_.c_str()) ==
+            base::StringPiece::npos)
           return false;
         break;
 
       default:
         break;
     }
   }
   if (tiebreaker_ && !use_tiebreaker_for_sort_only_)
     return tiebreaker_->Acceptable(sample);
   return true;
@@ skipping 112 matching lines @@
       if (sample.death_thread()) {
         base::StringAppendF(output, "All deleted on %s ",
                             sample.DeathThreadName().c_str());
       } else {
         output->append("All still alive ");
       }
       wrote_data = true;
       break;
 
     case BIRTH_FILE:
-      base::StringAppendF(output, "All born in %s ",
-                          sample.location().file_name());
+      output->append("All born in ");
+      sample.location().file_name().AppendToString(output);
+      output->append(" ");
       break;
 
     case BIRTH_FUNCTION:
       output->append("All born in ");
       sample.location().WriteFunctionName(output);
       output->push_back(' ');
       break;
 
     default:
       break;
@@ skipping 13 matching lines @@
                         (combined_selectors_ & BIRTH_THREAD) ? "*" :
                           sample.birth().birth_thread()->ThreadName().c_str(),
                         (combined_selectors_ & DEATH_THREAD) ? "*" :
                           sample.DeathThreadName().c_str());
   sample.birth().location().Write(!(combined_selectors_ & BIRTH_FILE),
                                   !(combined_selectors_ & BIRTH_FUNCTION),
                                   output);
 }
 
 }  // namespace tracked_objects