Issue 7778024: Updating Chrome Linux installer to use nacl_helper instead of nacl_helper.so

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7778024: Updating Chrome Linux installer to use nacl_helper instead of nacl_helper.so (Closed)

Created:
9 years, 3 months ago by Brad Chen

Modified:
9 years, 3 months ago

Reviewers:
Mark Seaborn, Use chromium.org instead, Roland McGrath

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Closing this; it was folded into Roland's related CL. Updating Chrome Linux installer to use nacl_helper instead of nacl_helper.so BUG=92964 TEST=manual for now

Patch Set 1 #

Patch Set 2 : Update Chrome Linux installer to use nacl_helper instead of nacl_helper.so #

Patch Set 3 : Additional fix for ChromeOS #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	chrome/chrome_installer.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/build/chromeos/FILES.cfg	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/build/linux/FILES	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/build/linux/FILES.cfg	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Roland McGrath

It's commented out in chrome/tools/build/chromeos/FILES.cfg but you should change it there too just to keep ...

9 years, 3 months ago (2011-08-30 22:10:00 UTC) #2

Brad Chen

Thanks for pointing that out. I will look into it. On Tue, Aug 30, 2011 ...

9 years, 3 months ago (2011-08-30 22:25:19 UTC) #3

Brad Chen

9 years, 3 months ago (2011-08-30 22:27:00 UTC) #4

I will add this file which I didn't know about, and also update the related
wiki...

Brad

On Tue, Aug 30, 2011 at 3:25 PM, Brad Chen <bradchen@google.com> wrote:

> Thanks for pointing that out. I will look into it.
>
>
> On Tue, Aug 30, 2011 at 3:10 PM, <mcgrathr@chromium.org> wrote:
>
>> It's commented out in chrome/tools/build/chromeos/**FILES.cfg but you
>> should
>> change it there too just to keep it up to date.
>>
>> Otherwise, LGTM.
>>
>>
>>
http://codereview.chromium.**org/7778024/<http://codereview.chromium.org/7778...
>>
>
>

Expand Messages | Collapse Messages